- added (short) third paragraph explaining how to reach the color picker
- made the 2nd sentence of the first paragraph a bit more readable (hope the new parentheses don't cause too many upsets ;-) )

(Also see http://drupal.org/node/197297#comment-660846 ... re-rolled patch against HEAD.)

CommentFileSizeAuthor
#4 color-text-2.patch2.58 KBkeith.smith
color.module.help_.patch2.3 KBgpk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

keith.smith’s picture

These changes look good to me. I think the Garland and Minelli stuff look better as you have it (as a parenthetical), but, as you say, someone may have another view of that. Thank you for reversing the not on that sentence, that's much more readable.

In
+ $output .= '<p>'. t('To change the color settings for a compatible theme, select the "configure" link for the theme on the main <a href="@url">themes administration page</a>.', array('@url' => url('admin/build/themes'))) .'</p>';

you say "main themes administration page" to perhaps distinguish from the individual theme configuration pages? I'm not sure "main" adds much there, since none of the individual theme configuration pages is the "themes administration page" -- I mean, you are already linking to a specific page, here. That's a very minor point though and doesn't even deserve CNW.

gpk’s picture

Thanks Keith, yes I take your point, guess I was trying to emphasize which page I was talking about.

Gábor Hojtsy’s picture

Status: Needs review » Needs work

$ patch -p0 < color.module.help_.patch
(Stripping trailing CRs from patch.)
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- modules\color\color.module.1.32 Sun Dec 16 11:54:09 2007
|+++ modules\color\color.module Sun Dec 16 12:43:23 2007
--------------------------
File to patch: modules/color/color.module
patching file modules/color/color.module
Hunk #1 FAILED at 7.
1 out of 1 hunk FAILED -- saving rejects to file modules/color/color.module.rej

While we are at this, let's remove the "main" word :)

keith.smith’s picture

Status: Needs work » Needs review
FileSize
2.58 KB

Rerolled the patch, and removed "main."

Dries’s picture

Status: Needs review » Fixed

Great. I've committed this to CVS HEAD.

gpk’s picture

Thanks Dries,

and thanks Keith also - you beat me to it!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.