Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
- added (short) third paragraph explaining how to reach the color picker
- made the 2nd sentence of the first paragraph a bit more readable (hope the new parentheses don't cause too many upsets ;-) )
(Also see http://drupal.org/node/197297#comment-660846 ... re-rolled patch against HEAD.)
Comment | File | Size | Author |
---|---|---|---|
#4 | color-text-2.patch | 2.58 KB | keith.smith |
color.module.help_.patch | 2.3 KB | gpk | |
Comments
Comment #1
keith.smith CreditAttribution: keith.smith commentedThese changes look good to me. I think the Garland and Minelli stuff look better as you have it (as a parenthetical), but, as you say, someone may have another view of that. Thank you for reversing the not on that sentence, that's much more readable.
In
+ $output .= '<p>'. t('To change the color settings for a compatible theme, select the "configure" link for the theme on the main <a href="@url">themes administration page</a>.', array('@url' => url('admin/build/themes'))) .'</p>';
you say "main themes administration page" to perhaps distinguish from the individual theme configuration pages? I'm not sure "main" adds much there, since none of the individual theme configuration pages is the "themes administration page" -- I mean, you are already linking to a specific page, here. That's a very minor point though and doesn't even deserve CNW.
Comment #2
gpk CreditAttribution: gpk commentedThanks Keith, yes I take your point, guess I was trying to emphasize which page I was talking about.
Comment #3
Gábor Hojtsy$ patch -p0 < color.module.help_.patch
(Stripping trailing CRs from patch.)
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- modules\color\color.module.1.32 Sun Dec 16 11:54:09 2007
|+++ modules\color\color.module Sun Dec 16 12:43:23 2007
--------------------------
File to patch: modules/color/color.module
patching file modules/color/color.module
Hunk #1 FAILED at 7.
1 out of 1 hunk FAILED -- saving rejects to file modules/color/color.module.rej
While we are at this, let's remove the "main" word :)
Comment #4
keith.smith CreditAttribution: keith.smith commentedRerolled the patch, and removed "main."
Comment #5
Dries CreditAttribution: Dries commentedGreat. I've committed this to CVS HEAD.
Comment #6
gpk CreditAttribution: gpk commentedThanks Dries,
and thanks Keith also - you beat me to it!
Comment #7
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.