The help text says: "List and edit site comments and the comment moderation queue.". The menu point says "Approval queue". This is confusing, so we need to change either both to "approval queue" or "moderation queue".

I suggest using "moderation queue" because it just sounds more senseful to me.

CommentFileSizeAuthor
#9 201490-9.patch4.14 KBkeith.smith
#6 comment_approval_queue_before.png30.36 KBkeith.smith
#6 comment_approval_queue_after.png30.53 KBkeith.smith
#6 201490.patch4.43 KBkeith.smith
#4 approval-queue.patch1.98 KBlilou
#2 201490.patch929 bytesBevan

Comments

blakehall’s picture

blakehall commented
Status: Active » Closed (fixed)

Looks like this is fixed in CVS now.

Marking closed, but feel free to re-open if I'm wrong.

Bevan’s picture

Bevan commented
Version: 6.x-dev » 7.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new 201490.patch929 bytes

Using grep 'Approval' * -ri and grep 'Moderation' * -ri There were far more occurrences of 'approval', especially in code. Additionally I think 'Approval' makes more sense here than 'Moderation', given the context that most people use this feature. I found three occurrences of 'Moderation' in comment module. two of them are fixed in this patch. One is not fixed because it makes sense in it's place.

The three occurrences, using grep 'moderation' modules/comment -ri;

modules/comment/comment.module:      return '<p>'. t("Below is a list of the comments posted to your site that need approval. To approve a comment, click on 'edit' and then change its 'moderation status' to Approved. Click on a subject to see the comment, the author's name to edit the author's user information, 'edit' to modify the text, and 'delete' to remove their submission.") .'</p>';
modules/comment/comment.module:    'description' => 'List and edit site comments and the comment moderation queue.',
modules/comment/comment.module:        drupal_set_message(t('Your comment has been queued for moderation by site administrators and will be published after approval.'));

Goes into d7 due to lang string freeze.

Bevan’s picture

Bevan commented
Title: Change "approval queue" to "moderation queue" » Change "moderation queue" to "approval queue"

this would be a good one for newbie to do

lilou’s picture

lilou commented
Component: comment.module » user interface text
StatusFileSize
new approval-queue.patch1.98 KB

Reroll.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

keith.smith’s picture

keith.smith commented
Status: Needs work » Needs review
StatusFileSize
new 201490.patch4.43 KB
new comment_approval_queue_after.png30.53 KB
new comment_approval_queue_before.png30.36 KB

Restart on this one. The attached patch does change "moderation" to "approval". More importantly, it seeks to correct the instructions at the top of /admin/content/comment/approval, since the existing text is incorrect.

Comment module tests still pass.

Edit: forgot to attach the patch.

catch’s picture

catch
he/him
Primary language English
commented
Title: Change "moderation queue" to "approval queue" » Clean up 'approval' typos in comment module
Status: Needs review » Needs work

No longer applies.

keith.smith’s picture

keith.smith commented

And, looking at the screenshots from my earlier patch, I misspelled "individually".

keith.smith’s picture

keith.smith commented
Category: task » bug
Status: Needs work » Needs review
StatusFileSize
new 201490-9.patch4.14 KB

Rerolled patch and fixed the spelling error.

Plus, this is a bug. The current help text is incorrect.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.