Steps to repeat:
1. As admin create a new node and uncheck the automatically create alias box and create a manual alias
2. As a user who cannot admin paths but who can edit nodes of that type edit the node

Expected results:
Path stays as was specified in step 1

Actual results:
Path is changed to the pattern defined for the node.

CommentFileSizeAuthor
#3 better_alias_protection_201659.patch2.13 KBgreggles
#3 better_alias_protection_201659.patch2.13 KBgreggles

Comments

Anonymous’s picture

Anonymous (not verified) commented

+1 Tracking

txcrew

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review

and here's a patch that works under the following scenarios:

// If the box is checked we should alias it
// If the box is not checked but it's already being managed by Pathauto we should alias it
// If the box is not checked, it's not being managed by Pathauto, but this is the submit, we should do it

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new better_alias_protection_201659.patch2.13 KB
new better_alias_protection_201659.patch2.13 KB
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Slight problem with this patch (or maybe it was another one) - since none of the aliases from before 5.x-2.1+ are in url_alias_extra, pathauto thinks that the admin manually created all of them...

I'm starting to wonder if this can work in this way without a patch to core...

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

+1

This is a *major* annoyance at the moment.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Assigned: greggles » Unassigned

It doesn't need a +1 - it needs testing, reviews, and a few other patches.

See http://groups.drupal.org/node/8318 for the roadmap of what needs to be fixed to make this work properly.

Unassigning myself.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

I'm sure that's what it needs. That's what all issues need. I'm only showing that there's another person bugged by this. That's all :)

Thanks for those links. If I find the time, I'll work on it.

neclimdul’s picture

neclimdul
He/Him
commented

interested party subscribing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

This patch itself works fine. We just need work on the other two issues in http://groups.drupal.org/node/8318

Applied to both 5.x-2 and 6.x.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Yay for the progress! Thanks greggles :)

giggler’s picture

giggler commented

Has this been applied to 5.x-2.x-dev (just downloaded today)? Because it see to still do the same. Uncheck Automatic alias and change the alias url, then hit submit. It will say:

* The menu item Aliasname has been updated.
* The Page has been updated.

However the menu still goes to the old alias...and I can't get the alias to change. Typing in the new alias directly will give you the same page.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

This exact bug has been fixed (I believe) but in general this whole area of functionality doesn't work well and I plan to take it out. There's just no way to really make this work well outside of core. It's on my list of things to fix in core for Drupal7, though.

See http://groups.drupal.org/node/8318 and http://groups.drupal.org/node/8063 for more information on why this is broken and why I'm going to take it out.

giggler’s picture

giggler commented

Right now, it seem like the way to get around this is just uncheck "automatic alias", change the path and hit save. It will sometimes give an error saying db is duplicated (but the new alias is still created), so that's not a problem.

Then go to Site building > URL aliases and delete the old alias (content/oldalias), and the new alias actually will take affect for the menu.

So the problem if you do not do the above seem to be that there are two alias going to the same system node (node/# was duplicated). The way to solve this in the coding "might" be that when there is an alias where the system node is duplicated, ask "do you want to replace this". Once you click yes, then it will delete the old one. This does not solve the problem of the "automatic alias" being checked still afterwards, but at least the new updated alias will work and I'm not bothered it being checked since you still can uncheck and redo the process...as long as the alias actually changes.

I'm not a coder, so I don't know if this is possible, but it seem like a workaround for this part of the bug...

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.