Closed (fixed)
Project:
Windows Live ID Integration
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Dec 2007 at 12:24 UTC
Updated:
16 Jan 2008 at 11:12 UTC
With WinLiveID module enabled but with no users having a live id activated get the following php error...
notice: Undefined index: winliveid_login_activate in C:\WWWRoot\drupal\modules\winliveid\winliveid.module on line 93.
Comments
Comment #1
panis commentedWhat is the error level for your PHP settings?
This is just a warning that the variable is not initialized when it is accessed. I do not have this error show up unless I set display_errors to E_ALL or E_WARNINGS.
The module should work even with this. Is it not working?
Comment #2
kwikone commentedIt does appear to be working (I have not fully tested since my system is behind firewall/router/nat and it does not work through that for some reason that I have not more fully investigated) but I have not been able to test it more that I just indicated. It is just that ( I am a bit of a purist :-) ) on my development system I am getting the E_NOTICE warning. And, being the purist that I am (I am from the old school where it is proper coding practice to initialize variables before using them (unless the using of them is the initialization or declaration of them), I decided to report it so that it could be at least queued for attention.
Comment #3
kwikone commentedComment #4
panis commentedif you look at the line - the code checks to see if the variable exists and this generates the error.. That is a bit difficult to overcome..
Comment #5
kwikone commentedActually, that line is easy now that I looked at it.
instead of:
if( $_SESSION['winliveid_login_activate'] ) {it should be:
if( isset($_SESSION['winliveid_login_activate']) && $_SESSION['winliveid_login_activate']) {that same type of check is done further down on a different session variable. And it will eliminate the php error and watchdog entry
Comment #6
panis commentedComment #7
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.