As noted by Gabor in #193333 the taxonomy "reset to alphabetical" button uses the same url as the form, meaning the help texts are displayed - potentially misleading and confusing.

The delete button on the comment administration pages also does the same thing. However content_type delete (and node delete, revision delete and others) all use separate confirmation pages.

I think we should standardise on separate urls for those confirmation buttons - the help texts could be confusing, and these are quite critical administrative operations that should be standardised as much as possible.

CommentFileSizeAuthor
cotent_type_delete.png7.62 KBcatch
confirm_help.png18.1 KBcatch

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

The taxonomy drag and drop patch actually introduced more confirm forms submitting on the same paths, not just this one.

catch’s picture

catch
he/him
Primary language English
commented
Title: Confirmation pages should not use same url as the form » taxonomy delete broken + confirmation pages should not use same url as the form
Priority: Normal » Critical

That's true: taxonomy/edit/term/2 delete button redirects to itself, has no confirm form, and still throws php errors. Bumping this to critical.

    * warning: Illegal offset type in isset or empty in modules/taxonomy/taxonomy.module on line 1005.
    * warning: Illegal offset type in modules/taxonomy/taxonomy.module on line 1006.
    * warning: Illegal offset type in modules/taxonomy/taxonomy.module on line 1009.
    * notice: Trying to get property of non-object in modules/taxonomy/taxonomy.admin.inc on line 835.
    * notice: Trying to get property of non-object in modules/taxonomy/taxonomy.admin.inc on line 840.
blackdog’s picture

blackdog commented

The patch in http://drupal.org/node/198865 takes care of the notices and errors on taxonomy deletion. Please correct me if I confuse things here.

catch’s picture

catch
he/him
Primary language English
commented
Priority: Critical » Normal

no, not at all. back to normal.

catch’s picture

catch
he/him
Primary language English
commented
Title: taxonomy delete broken + confirmation pages should not use same url as the form » Confirmation pages should not use same url as the form
catch’s picture

catch
he/him
Primary language English
commented

OK taxonomy delete issue from #3 is RTBC although the form still redirects to itself.
Comment multiple delete form just got fixed in #199510.

So unless there's others, it's primarily the taxonomy forms that need fixing now.

dpearcefl’s picture

dpearcefl commented
Status: Active » Postponed (maintainer needs more info)

Is this still a problem in current D6?

dpearcefl’s picture

dpearcefl commented
Status: Postponed (maintainer needs more info) » Active

Status: Active » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.