Drupal 6 Port

marcingy - December 18, 2007 - 23:25
Project:Domain Menu
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hi I have started porting over the core modules for domain access as I need them for a project which is going to go live on Drupal 6.

As a result I have done an initial port for domain_menu too. I have had to make a minor change in the way domain menu works because of the new menu system. The code originally placed in the init function can't be called from there any more as the conf variables are no longer used to build menus. Instead the code in an amended form needs to be added to the function phptemplate_preprocess_page which is held in a themes template.php file. A new file INSTALL.txt is provided to explain this step.

Hope you find this patch useful and it can serve as starting point for moving the module to drupal 6 as I don't know if you are planning new features etc.

AttachmentSize
INSTALL.txt795 bytes
domain_menu.module.patch5.75 KB

#1

defconjuan - September 4, 2008 - 23:46

how is this working, have you had any feedback?

#2

marcingy - September 5, 2008 - 00:05

No I haven't this project looks as if t may well be dead?

#3

canen - September 22, 2008 - 13:40

marcingy,

Would you like to maintain this module? Your contact form is disabled that's why I am asking here.

We needed it for a project we were working on at the time but to be honest it just hasn't been on my radar since. In addition we are still using Drupal 5 here so I am not sure when I'll start working on Drupal 6 versions of my modules.

#4

najibx - September 26, 2008 - 04:15

cool. Would be great if someone stand up.

For now, Could you post the 'whole' folder. I tried to patch ..it didn't go smooth, then when uploaded getting message
"This version is incompatible with the 6.5-dev version of Drupal core."

cheers

#5

marcingy - September 26, 2008 - 14:04

I have been given access to CVS. I wil be rerolling this patch at the weekend and will be looking to get a 6-x-dev repo set up.

#6

Aslak - October 6, 2008 - 13:55

Got a patch question?

What problems made you disable the "Restrict parent items to" form in the patch?
Its a feature i need, so i wondered if there are some special considerations that i have to pay attention to when i try to reimplement it?

@@ -48,24 +50,12 @@
'#value' => t('The menu module allows on-the-fly creation of menu links in the content authoring forms. The following option limits the menus in which a new link may be added. E.g., this can be used to force new menu items to be created in the primary links menu or to hide admin menu items.'),
);

- $authoring_options = $root_menus;
- $authoring_options[0] = t('Show all menus');
-
- $form['domain_settings_authoring']['menu_parent_items'] = array('#type' => 'select',
- '#title' => t('Restrict parent items to'),
- '#default_value' => $domain_menus['parent_items'] ? $domain_menus['parent_items'] : 0,
- '#options' => $authoring_options,
- '#description' => t('Choose the menu to be made available in the content authoring form. Only this menu item and its children will be shown.'),
- );
-

#7

Aslak - October 9, 2008 - 07:28

Hi

I made a hack that re-enables the "Restrict parent items to" functionality in marcingy's patched version of the module.
It is done by implementing the form_alter hook basically. I made this to scratch an itch, so its not a polished work of beauty, but i reckoned id share it anyway :)

There is an issue when you set the secondary links to the same as the primary links (then both show the pirmary links). Don't know what causes that.

AttachmentSize
hook_form_alter.patch 4.09 KB

#8

vasudev - October 19, 2008 - 16:52

subscribing

#9

chb - October 29, 2008 - 22:16

subscribing

#10

BWPanda - November 6, 2008 - 00:07

Looking forward to this module being released for Dupal 6.
Any idea when we can expect a dev version to start playing with?

#11

Aslak - November 10, 2008 - 08:41

@BWPanda

I think that this project is well dead. But on the bright side, a huge part of the domain_menu functionality was merged with the domain configuration module (See: http://drupal.org/node/330965)

It still doesn't filter the node-menu forms but its a step in the right direction :)

-A

#12

aaron1234nz - November 21, 2008 - 19:56

I can confirm that the domain_menu functionality exists in the domain_conf module, and that it does not require you to add anything to your themes template.php file. However the "Restrict parent items to" functionality is not there.

Aslak, I have taken your patch from #7 and integrated it into the domain_conf module.

AttachmentSize
domain_conf.module.patch 1.49 KB
domain_conf.admin_.inc_.patch 948 bytes

#13

eotinfotech - December 24, 2008 - 02:56

subscribing

#14

canen - January 4, 2009 - 02:46
Status:needs review» closed

This is now part of the core domain module. Closing.

 
 

Drupal is a registered trademark of Dries Buytaert.