I just noticed the code you have committed in http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/cgiirc/cgii...

Have you read http://drupal.org/node/66113 ?

Can you clarify your need for this code in cvs.drupal.org ?

Generally we ask people to add a line in the README.txt saying "download the code from thirdpartysite.org"

Comments

frollo’s picture

frollo commented
Version: » 5.x-1.x-dev

i apologize i forgot that was even in there though i can add the link to the url which i did in the project description. I am in no way affiliated with them however i wanted to bring that type of functionality into drupal as there isn't anything yet that allows the same usage. CGI:IRC is an irc client that runs from the web server and requires very low resources. This is different from other clients that run on a clients machine or even pjirc since it runs from the webserver and not the end user. Since it runs on the web server it bypasses a lot of firewall restrictions and issues that block people (for instance at work) to access a communities irc channel which is all set from the administrative back end.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I saw that you removed the readme file, but you either should have a reason for including all of their project files in this module OR should remove all of their files.

frollo’s picture

frollo commented

the reason that their files are in here is because it is their php script that is running. That is the client that is running on the server.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

If you read the policy on committing 3rd party code you'll see that's not a good enough reason.

So, please remove this code and instruct your users to download it from the 3rd party site.

frollo’s picture

frollo commented

this doesn't have anything to do with their site. all i did was take their code and make it work / configurable in drupal. you cannot find this anywhere else. denying this module here meens nobody benefits from it. if there is anything else you would like me to do to make it drupal friendly i can, but if you will not accept it the project goes to waste for all the users who would like this, as nothing else you have offers the same. and beyond that their license is a gpl as well.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

frollo - I apologize because I think I am not communicating well. Your code that integrates with Drupal should stay here.

The code in this subdirectory http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/cgiirc/cgiirc/ can be downloaded separately from http://cgiirc.org/download/ right?

cvs.drupal.org is not a place to store code from a separate project. So, you can remove that directory from cvs.drupal.org, leave your .module and .info file and then change the REAMDE.

People will still be able to use your module after they download the cgiirc project from the cgiirc.org page.

frollo’s picture

frollo commented

ohh thank you i can do that however i don't have a readme yet though i can add one :) i thought you were like NO DIE PROJECT!

edit: files should be removed and changes made

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Sorry if it came off that way. I should have specifically said "the code from the cgiirc.org" project instead of just "the code"

I don't personally plan to use your module, but of course it's always good to have more modules and I can imagine other people will find it useful.

frollo’s picture

frollo commented
Status: Active » Closed (fixed)

np thanks for the help :) and reply for closure