Closed (won't fix)
Project:
Drupal core
Version:
7.x-dev
Component:
block.module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
20 Dec 2007 at 01:51 UTC
Updated:
22 Mar 2010 at 12:27 UTC
Jump to comment: Most recent file
Making the block titles click-able (click -> config block) and removing the configure column as it was suggested at [1] would make the block configuration page much more intuitive and look cleaner.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | block_titles_clickable_2.patch | 3.76 KB | andreashaugstrup |
| #3 | block_titles_clickable.patch | 2.17 KB | andreashaugstrup |
Comments
Comment #1
Bevan commentedThis is something I may be reviewing at a more abstract level for d7 as part of the Season of Usability project. See #5 on http://groups.drupal.org/node/7965
Comment #2
Bevan commentedthe simpler solution discussed here is an improvement and is suitable for a newbie. plz tag for newbie
Comment #3
andreashaugstrup commentedI'm certainly a newbie. I have attached a patch that removes the "configure" link (removed in both block.admin.inc and in the tpl.php file) and changes the block title to a link pointing to the configure page.
The "Operations" column is left in place to make room for the "delete" links for custom blocks. There is a lot of empty space if you don't have any custom blocks.
I have tested that the drag/drop functionality still works. No problems found in Firefox, Opera and Safari.
Comment #4
panchoNice patch, Andreas! It's surely not your fault if I'm marking this with -1:
Therefore I'm tempted to mark this issue as won't fix, for now I leave it open, so it can be discussed more.
Comment #5
andreashaugstrup commentedI'm tend to agree with you, Pancho. I had to create the patch to see how the page would look without the configure links. If the 'delete' links where non-existant and the Operations column could be completely removed it would be a no-brainer to remove the configure links.
But since there has to be space for "delete" links the whole page looks tilted because of the nearly empty Operations column.
For good measure I have attached a new patch that updates the help text above the Blocks table (I know this kind of stuff effects translation work and it's a bigger deal) just so people can better evaluate. ...and I get more practice creating patches. :o)
Comment #6
Bevan commentedPatch applies cleanly. UI is improved. Well done!
The delete column should only exist if it is required. But this is a great first effort. Coding style looks great. Please run the coder module on it to see if there's anything I missed with my visual check.
I think this is too late for d6, but let's leave that for a commiter to decide.
Comment #7
Bevan commentedWoops, I should have refreshed before testing this and commenting. The previous comment was on the first patch, but it all applies to the second patch too. Additionally;
This will definitely need to be for drupal 7 because of the string change. Hopefully by that time the blocks won't even be in a table rows and it will have a better UI, but in the meantime this is great.
As for the help/intro text text, it's not quite correct grammar, and I think something like this is a little easier to read and clearer:
"Click the block name to configure its title, visibility and settings. Click add block to create a custom block."
Comment #8
Susurrus commentedWould this still be smart considering blocks are now sortable using a click and drag interface IIRC?
Comment #9
casey commentedThere have been lots of changes on the UI in D7. I don't think this issue still applies.
Feel free to reopen however if you don't agree.