(This is a split and lightweight version of http://drupal.org/node/199217)

mysqli and pgsql are PHP driver names, but not the name of database product. This patch try to fix:

  1. INSTALL.pgsql.txt -> INSTALL.postgresql.txt: just a simple rename.
  2. database.mysql-common.inc -> common.mysql.inc: a simple rename.
  3. DRUPAL_MINIMUM_PGSQL -> DRUPAL_MINIMUM_POSTGRESQL: a simple rename.
  4. Update connection error message: <code> is not allow for _db_error_page() as all error message will pass into theme('placeholder', $error). Moreover, update PHP modules description.
  5. Update xxx_is_available(): more specific and exactly PHP module checking.
CommentFileSizeAuthor
db_doc_cleanup-0.1.patch40.82 KBhswong3i

Comments

hswong3i’s picture

hswong3i commented

Shall we have this with D6?

moshe weitzman’s picture

moshe weitzman commented
Version: 6.x-dev » 7.x-dev

this is high risk and completely optional and minor.

hswong3i’s picture

hswong3i commented

@moshe: Well, I don't really understand why is it "high risky"... The first 3 changes are both simple rename without any functionality change, and mainly target for internal usage; 4. is a bug fix; 5. is a very simple feature enhancement, which is already proved as function in database.mysqli.inc implementation.

It may be optional and minor (as no functionality changes or enhancement), but I really not understand about how risky it is. Risky code is something we always hope to avoid for. Would you mind to provide more detail explanation for your comment?

lilou’s picture

lilou commented
Status: Needs review » Closed (won't fix)

The file structure for the database drivers has now changed completely.