There is a (maybe) important examination missing in the user.module's 379. line (the last stable version of the Drupal).

I'm developing now a Shibboleth Single Sign On authentication module which is able to create user accounts based on a remote database during the first login. In this time there are warnings, because $account->uid has no value yet and there is no such examination there.

This could be repaired by a simple patch. (Patch attached)

CommentFileSizeAuthor
user.module.071219.martoni.patch594 bytesmartoni

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Version: 5.5 » 7.x-dev
Status: Needs review » Postponed (maintainer needs more info)

I believe we might have solved this issue in another way with other changes to the authentication APIs, please retst with an updated, unpatched, version of Drupal core. Unfortunately, I do not know the specific issues involved offhand.

This line of code is the same in the development version of Drupal. If there is an issue, it is best to work on that version, which has more testing and patch reviewers, then backport as needed.

sun.core’s picture

sun.core commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

I never experienced this issue, and I'm using the Shared Sign-on module a lot.

Sorry, without further information this issue can only be marked as won't fix.

Feel free to re-open this issue if you want to provide further information. Thanks.