Actions modules doesn't work with action view module because it scans the name space of the action_view module as actions. This little patch makes sure it doesn't do that. Technically we should rename the actions to be more unique in future releases.

CommentFileSizeAuthor
action_action_views.patch475 bytessami_k

Comments

sami_k’s picture

sami_k commented
Project: Workflow » Actions
Version: 5.x-1.1 » 5.x-1.x-dev

Moving to accurate project.

Christefano-oldaccount’s picture

Christefano-oldaccount commented
Status: Needs review » Reviewed & tested by the community

Thanks, samik! This patch looks good to me and I'm marking it RTBC, but from the lack of recent activity in the Actions project I wonder if it will be committed any time soon.

jvandyk’s picture

jvandyk commented
Status: Reviewed & tested by the community » Closed (won't fix)

Don't name your module action_*. That namespace is used for action functions. The approach taken in this patch means we need to have a case for every module that violates this, and that check needs to be made for every function in the symbol table. FWIW, that's why the version of actions in Drupal 6 takes a different approach. It's also why the action (sic) module exists.

sami_k’s picture

sami_k commented

Related: http://drupal.org/node/202838
I agree with John VanDyk, action_views should be renamed to actions_views.