Swapping error/status messages and help text (in core themes)
marco.robotangel - December 20, 2007 - 22:51
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | theme system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
As suggested at [1]. Having error/status messages at the top should improve usablility a bit. When you submit your entry (e.g. at the blocks configuration page) browsers will start at the top again, it's good if you have the success/error messages right at the first sight then (especially if you have a lower screen resolution, you don't have to scroll then...).
[1] http://groups.drupal.org/node/7043
| Attachment | Size |
|---|---|
| swap_msgs_help.patch | 3.09 KB |
#1
+1: This makes a lot of sense and works as advertised. Next reviewer IMHO can set this rtbc.
#2
Marco did this as part of GHOP task #48. Well done Marco.
This is important IRT consistency. The user will always look in the same space for feedback about the last change they made. Without this patch the location of error and status messages changes randomly depending on the length of the help text.
Patch applies fine to CVS head. I tested this works on all core themes on the themes and block admin pages. RTBC.
I think this can go into d6 still, but not sure. No language strings are being changed. It isn't a feature. It's a non-critical usability bug.
#3
Committed, thanks.
#4
Automatically closed -- issue fixed for two weeks with no activity.