Panels 2 currently not compatible with jquery update

You're sure you don't have jquery_update installed?

I hope to work on that, because it's turning out to be a serious issue.

Bumping priority.

I set up a test site with jquery update and panels 2 and I can't find any incompatibilities at this time. I fear any incompatibilites we're seeing here may be the result of a complex interaction with other .js files.

We're going to need to narrow down exactly what is failing with minimal additions so it can be reproduced.

I tried getting panels 2 to work with jquery_update and i encounter an error with the modalcontent jquery plugin (panels/js/lib/mc.js).

The error is related to the .top and .left functions which don't seem to exist in jquery 1.1 +

the modalContent plugin seems to be discontinued and hasn't been updated to work with newer versions of jquery - see http://dev.jquery.com/ticket/501

The link to content drupal module seems to have encountered similar problems with the top function here
http://drupal.org/node/147025#comment-561028

I've added a patch that fixes the issue i was having (when you go click the panels settings icon on the content tab) and that now works.

Whether there are more problems with jquery 1.1, i'm not sure, but for me at least its usable.

HTH

Ben

Hey there,

I too have this problem once I install Jquery Update.

Here is some info I can provide:

Drupal version : 5.7
JQuery is 1.1.2
php : 5.2.5

Modules installed related to anything JS:

Fasttoggling
Js tools 5.x-0.8
Panels 5.x-2.0-beta2
jQuery Update 5.x-1.0
jQuery Interface 5.x-1.0

that's it!

I will test the patch posted above and report back,

Any more info I could provide?
Patchak

subscribing.

I tested the patch attached at #9 and it does not solve anything for me.

I get this error in firebug when I try to add or modify some content

syntax error
};\n

on line 111

Any ideas?

@Merlinofchaos : maybe you could try to add jstools to your test install to see if the panels 2 still works with that module installed?

merlinofchaos is *aware* of this. He simply has not yet found the time to make it compatible.

Hey Wim.
According to #8 we are still looking for which module creates the incompatibility? Just trying to help here.

Just to add a little more info.. I tried to come back to the old jQuery version that comes with drupal 5 and to disable jQuery interface and jQuery update modules.

I can have arguments working with both versions of jQuery, the pop up for arguments works, but it did not re-enable the pop up for the content tab and sections.

So I think it's not only about jQuery update and the jQuery versions since putting back the old jQuery version does not seem to change anything...

I get these errors on firebug after reverting to the original jQuery...

Drupal.Panels has no properties
Drupal.Panels.clickAdd = function() {
display_editor.js (line 9)

Drupal.Panels has no properties
Drupal.Panels.Checkboxes = {};
checkboxes.js (line 3)

Drupal.Panels has no properties
Drupal.Panels.Subform = {};
modal_forms.js (line 3)

Hope this helps, I'm planning on removing all Js related modules one at a time until something works with jQuery update like on merlin's test install, I'll tell you how it goes.

Patchak

patchak: That's a different bug. -dev fixes that one.

I just installed the latest dev version, maybe I was out of date for a couple of weeks... It seems to have fixed the issue. I installed the jQuery version that comes with jQuery update, and now all is fine.

Great!

Patchak

so are you also successfully using other.js modules with panels and the jquery update? if so, which ones?

http://drupal.org/node/228700 is duplicate of this. contains alternate patch that should be looked at.

still not working for me...

does this bug affect only the dev version or both the dev and the beta version?

@GraceAhora: I can confirm that panels 2 is working for me with all the modules installed in my comment in no. 10... I;m now using the dev version of panels 2 and the bug seems gone.

Patchak

Patchak: it is now also working for me with all my modules enabled. My problem had nothing to do with js. In fact it was because the cache was too small. See http://drupal.org/node/230337

I had the same symptoms but turned out firefox wasnt loading some of the .js files, it must have picked them up as 404 initially, i hit shift+reload and magically it started working again :(

+1 that the patch in #9 + the current -dev version fixes this bug.

Patch has been committed; this issue has been resolved as of beta3.

Hope it's ok for me to re-open this issue. There was one more slight problem in mc.js causing problems with the window resize function. See attached patch.

Applied. Thanks katbailey!