Internationalization (i18n) compatibility

I have a patch for 5.x-1.0 that works with i18ntaxonomy.module -- that must be enabled for this to work.

--- tagadelic.module_orig       2008-06-11 12:02:52.609072000 -0500
+++ tagadelic.module    2008-06-11 12:05:11.778240000 -0500
@@ -283,7 +283,10 @@
  */
 function theme_tagadelic_weighted($terms) {
   foreach ($terms as $term) {
-    $output .= l($term->name, taxonomy_term_path($term), array('class'=>"tagadelic level$term->weight", 'rel'=>'tag')) ." \n";
+    $name = $term->name;
+    if (module_exists("i18ntaxonomy"))
+      $name = t($term->name);
+    $output .= l($name, taxonomy_term_path($term), array('class'=>"tagadelic level$term->weight", 'rel'=>'tag')) ." \n";
   }
   return $output;
 }

Thanks, the patch looks easy and promising, but is unfortunately not working for me. I'm using also panels2 so will check what else could influence it.

Because you are changing a theme function I would rather override it in template.php so it is still working when upgrading the module:

In template.php:

/**
 * Tagadelic module: theme function that renders the HTML for the tags
 * Make terms language dependend when using i18ntaxonomy module
 */
function phptemplate_tagadelic_weighted($terms) {
  foreach ($terms as $term) {
    $name = $term->name;
    if (module_exists("i18ntaxonomy")) {
      $name = t($term->name);
      }
    $output .= l($name, taxonomy_term_path($term), array('class'=>"tagadelic level$term->weight", 'rel'=>'tag')) ." \n";
    }
  return $output;
}

This is not the proper solution.
You should not have to modify every module in order to make another (i18ntaxonomy) work.

Can you please see if we maybe use a wrong API, so that i18n cannot override our tags?

continued at 141682: access control aware tag clouds