Found the following regression while examining queries with Devel module: With the introduction of dynamic (uncached) menu entries in Admin Menu 2.x, the whole menu tree is built on every page request. This had been solved in 1.x by caching the final rendered output, but is now causing performance degradation again.

CommentFileSizeAuthor
#2 admin_menu.patch6.21 KBsmk-ka

Comments

smk-ka’s picture

smk-ka commented

The problem is the l()/url() functions, which look up aliases for every link. I think we had code in 1.x that avoided these lookups.

smk-ka’s picture

smk-ka commented
Version: 5.x-2.1 » 5.x-2.2
Assigned: Unassigned » smk-ka
Status: Active » Needs review
StatusFileSize
new admin_menu.patch6.21 KB

The attached patch avoids calling url() on output by storing the processed urls in the cache. This accelerates the output of the admin menu by 30% and saves us a few hundred queries.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Thanks, committed!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.