I'm not quite sure where this bug comes from, it may be core modules. I've got lost trying to work out what does what (as an aside it would be useful if Drupal API docs as well as saying what a function uses said what used that function, as it is you can go down the tree but not up AFAIK).

The bug is that the form buttons are not styled but the normal grey things. This only occurs on the right block (maybe the left, have not tried that). Search form in the content is styled correctly. See

 <div class="container-inline">
   <div class="form-item">
     <input id="edit-search-block-form-keys" class="form-text" type="text"
          title="Enter the terms you wish to search for." value="" size="15"
            name="search_block_form_keys" maxlength="128"/>
   </div>
   <input id="edit-submit" class="form-submit" type="submit" value="Search" name="op"/>
   <input id="edit-search-block-form" type="hidden" value="search_block_form" name="form_id"/>
</div>

Compare this with the search in content

<div class="form-item">
  <label>Enter your keywords: </label>
  <div class="container-inline">
    <div class="form-item">
      <input id="edit-keys" class="form-text" type="text" value="" size="40" name="keys" maxlength="255"/>
    </div>
    <input id="edit-submit" class="form-submit" type="submit" value="Search" name="op"/>
  </div>
</div>
<input id="edit-search-form" type="hidden" value="search_form" name="form_id"/>

There is an outer form-item on the content search that catches the submit button. The right sidebar search doesn't have that (same happens on login too).

My fix is to include form-submit in the form-item class on the css, so line 159 in the css becomes

.form-item input, .form-item submit, .form-submit, .form-item textarea{background:url("images/bg-input.jpg") repeat-x;border:1px solid #bbb;font:1em Verdana, Arial, Helvetica, sans-serif;margin:0;padding:3px;}

There is another problem I have that I've yet to track down and I welcome suggestions where to look on that. I have login on the right side bar too. When logged in this completely disappears rather that changing to a log out button. Why?

Comments

jacine’s picture

jacine
she/her
Location New York
commented
Status: Active » Closed (fixed)

Hi malc_b,

I purposely left styling off the form-submit class, so that each browser will show them in their native browser style. If I were to add that class the native browser styles for buttons would be ignored. I agree that styled ones would look nicer... Ideally using images and rounded edges, but they are a real pain to get cross-browser compatible, and would require a lot of modification to the markup, which IMO isn't worth the trouble at this point.

As for the logout issue, that is the way Drupal works. Drupal doesn't add a logout button, once you log in. You may want to look at LoginToboggan. It's a great module, and includes a logout link for you.

:)

malc_b’s picture

malc_b commented

Thanks for the reply. I have added a login button to get over the problem. I hadn't realised that was standard drupal behaviour as other themes I tried seem to change the login form for a logout button. I'll have to look into how those themes did it.

I'm not sure you quite got the drift of my post. When search fails and it displays the search again or advanced form in the main content section the button on that form IS styled. On the buttons on the blocks (login, search) are not styled. I've changed the css to include all buttons. True the button is square but at least it is off-white, rather than standard grey.

BTW I rather thought that adding a background image might be a sort of work around. The button size would need to be fixed and you would actually seen the normal button and the image so it would be have to be a round corner top, square bottom button.