upgrade comment notify for 6.x

greggles - December 22, 2007 - 14:38
Project:Comment Notify
Version:5.x-2.x-dev
Component:Code
Category:task
Priority:normal
Assigned:greggles
Status:closed
Description

Just a tracking issue. I don't think any work has started on this, but I wanted to at least create an issue for people to subscribe to and where people could discuss efforts and perhaps post patches.

#1

dennys - December 30, 2007 - 05:42

subscribing

#2

greggles - January 19, 2008 - 13:21

FWIW, I would like to sort out a bunch of the issues in the queue, create a 5.x-1.4, and only after that's been stable for a while do I think that a 6.x makes sense.

If (multiple) folks really want to have a 6.x now and would help with testing I'd be pursuaded to do it.

#3

cantidubi - February 22, 2008 - 14:25

Really necessary

#4

greggles - February 22, 2008 - 15:14

I'd like to get http://drupal.org/node/222740 finished before worrying about a 6.x port.

Also "really necessary"? if it's so necessary perhaps you could put up a bounty for the successful completion.

#5

greggles - April 29, 2008 - 21:28
Status:active» needs work

So, here's a start based on coder module. Since 6.x requires the schema module, I think that #232564: refactor data structure so core tables are not altered and move towards PostgreSQL compliance should be fixed first...

AttachmentSize
203223_comment_notify_6.x_upgrade.patch 5.52 KB

#6

Yoran - May 25, 2008 - 05:58

I used your patch but there was some problem with locales and mail management in D6 API. I also had some incompatibility between you big query and Postgresql. So I modified the source in order to make it work with D6 and Psql. It's not a "good" patch as I didn't tryied to make it compatible with Postgresql and I just disconnected Locales. But perhaps this will help you to finish the migration.

Regards and thanks for this very important module !

Patch applies on your last dev version.

AttachmentSize
comment_notify_5.x-1.x-dev_6.x.patch 9.52 KB

#7

Fayna - May 30, 2008 - 03:49

Subscribing so I can help test.

#8

rapsli - June 2, 2008 - 11:47

I'll test as soon as there's a first release ... alpha or pre alpha is fine.

#9

hectorplus - June 8, 2008 - 23:03

Subscribing

#10

encho - July 18, 2008 - 10:41

Subscribing

#11

greggles - July 23, 2008 - 22:11

Hi folks. If you'd like to help move this forward I need reviews/testers for #232564: refactor data structure so core tables are not altered and move towards PostgreSQL compliance. That is important to get done prior to moving to Drupal6 due to the new Schema API module.

#12

greggles - July 30, 2008 - 00:05
Version:5.x-1.x-dev» 5.x-2.x-dev
Status:needs work» needs review

Ok...here's an updated version now that I've done the other things that I wanted to fix prior to an upgrade.

Note that this is a patch against the 5.x-2.x version of code (aka CVS HEAD) which hasn't yet been packaged and published, though it will be at http://drupal.org/node/288722 in a few hours...

Testers welcome!

Thanks.

AttachmentSize
203223_comment_notify_6x_12.patch 15.44 KB

#13

greggles - July 30, 2008 - 14:58

Note also that if you are upgrading from Drupal 5.x you will need to first upgrade to the comment_notify 5.x-2.x and run update.php prior to upgrading (the same as CCK does it).

#14

greggles - August 6, 2008 - 23:28
Assigned to:Anonymous» greggles
Status:needs review» fixed

And...committed.

This may still have some bugs in it...but I'll be making a release soon.

#15

greggles - August 7, 2008 - 00:25
Status:fixed» needs work

Well...that patch missed a little bit. My initial testing seems to be that it's working, but all of the newlines are gone so I'll have to see how to add those back.

#16

greggles - August 25, 2008 - 14:40
Status:needs work» fixed

There's a new issue for the line break problem so I'm going to call this fixed. #299548: Line breaks not showing up in email

#17

Anonymous (not verified) - September 8, 2008 - 16:03
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.