Comments

hass’s picture

Subscribe

hass’s picture

Assigned: Unassigned »

I'm working on this.

hass’s picture

Status: Needs work » Needs review
StatusFileSize
new16.07 KB
new109.61 KB

I've finished the D6 port.

This patch is build against current CVS HEAD.

Robrecht Jacques’s picture

Status: Needs review » Needs work

Could you make the patch against current DRUPAL-5 branch instead? That way it's easier to see what has changed compared to 5.x.

I'll look at it then and create a 6.x version soon.

hass’s picture

Status: Needs work » Needs review
StatusFileSize
new42.35 KB
new105.6 KB

Here is the patch against D5-dev.

If you wonder why:
1. nodewords_update_3 and prior updates are removed... _system_update_utf8() is no longer supported in D6 and upgrades from 4.7.x, too.
2. nodewords_update_4 is no longer required. Sections have a weight of -10.
3. nodewords_update_5 is not required, while D6 does this them self on modules page...

And the next update must be named 6000 or 6100 (not sure).

Robrecht Jacques’s picture

Status: Needs review » Reviewed & tested by the community

OK, this looks quite straightforward.

I suppose:

 /**
+ * hook_theme() registry
+ */
+function something_theme() {
+  return array(
+    'nodewords_content' => array(
+      'arguments' => array('tags'),
+    ),
+  );

will need to be nodewords_theme().

Doesn't hook_scheme() need to be in a seperate file (nodewords.scheme)? I'll check the docs.

Panels & views still need to be tested as soon as they release a D6 version. That's ok.

Removal of hook_update_XX(): makes sense.

I'll release a 6.x-1.0-RC1 today.

Thanks a lot!

affinityuser’s picture

StatusFileSize
new1.15 KB

Hey everyone, I have only just begun exploring drupal last month, this is my first post to drupal ever, so i'll hope you'll forgive me for not knowing proper procedures to post fixes for this module.

After installing this module it gave me an error when accessing my forums:

Fatal error: Call to undefined function taxonomy_get_vocabulary() in C:\wamp\www\new new site\modules\nodewords\metatags\description.inc on line 41

So the fix for this is:

case 'vocabulary':
// TODO: probably we have to do a db_rewrite_sql() query here so access is restricted

$voc = taxonomy_get_vocabulary($ids[0]);

if ($voc) {
$value = $voc->description;
}
break;

$voc = taxonomy_get_vocabulary($ids[0]);

Needs to be changed to:

$voc = taxonomy_vocabulary_load($ids[0]);

As per this post: http://drupal.org/node/181809#comment-654841

A corrected file is included if you wish to correct or update the patch. Thankyou to everyone who has made drupal such a great online community plumbing system. All you contributers deserve medals.

hass’s picture

Ups, yes... must be function nodewords_theme() {

hook_scheme() should be in .install file... this have changed in september... :-)

hass’s picture

Status: Reviewed & tested by the community » Needs work

@affinityuser: good catch.

@Robrecht: I missed to test taxonomy... maybe the http://drupal.org/node/114774#taxonomy-revisions needs more changes... not sure. We need to reroll for sure... i will do this later the day.

hass’s picture

Status: Needs work » Needs review
StatusFileSize
new37.62 KB

Reroled patch with above fixes and some minor bugfixes found by coder module.

I have removed the tags directory deletion from the patch. I hope you are able to delete this folder first, see issue http://drupal.org/node/212136.

Robrecht Jacques’s picture

Status: Needs review » Fixed

OK, I have committed the latest patch in DRUPAL-6--1 branch. A downloadable package will only be available when the scripts on drupal.org run again.

If you find problems with 6.x-1.x-dev, please open a new issue.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.