Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
There are way too many theme functions / template files in core. Some are similar (if not identical) and should be consolidated.
Proposed resolution
We have two options:
- Remove theme_book_admin_table and call
theme('table')
instead. - If we really do need a separate preprocess function for the admin tables in book module, then call theme('table__book_admin') instead of
theme('table')
and add all our preprocess magic intotemplate_preprocess_table__book_admin()
Remaining tasks
Decide which of the 2 options above to pursue, and do it.
User interface changes
None.
API changes
Removal of theme_book_admin_table
Related Issues
#1812684: [meta] Consolidate all table templates and add theme_hook_suggestions
#1968982: Convert book theme tables to table #type
Comment | File | Size | Author |
---|---|---|---|
#1 | 2035905-remove-theme_book_admin_table-1.patch | 7.93 KB | joelpittet |
Comments
Comment #1
joelpittetI thought I'd give this a stab to get it started and maybe someone can pick it up from here.
The values aren't showing but most everything else is rendering. May be due to something render element does...
Comment #3
joelpittetWoops, should have checked this is a dupe, will compare above with this #1968982: Convert book theme tables to table #type