I tried to submit a testing story, so I filled fields URL, title, desc but Tags left empty.
Choose category and clicked preview button. Error message appeared because Tags can not be empty.


Now when I typed some tags and clicked preview, error message was hidden, but border of Tags field is red and is not possible to submit story.


I tried it on my local instalation of Drigg and on fsdaily.com and results are same.

Comments

japan_san’s picture

Assigned: japan_san » Unassigned
mercmobily’s picture

Hi,

Looking into it...

Merc.

wotstheguts’s picture

Version: » 5.x-1.x-dev

I have a related issue. I did a manual install of Drigg on an existing Drupal installation. I go to Create Content and select Scoop. I enter Story's URL then tab to Story's Title and start entering a title. Both fields turn red and an exclamation symbol appears in the field below "Submit Scoop", but with no error message. I fill in the remaining fields including tags but it just hangs when I click preview or submit.

I also get the following error when I click on the "newest" link, and lose the theme formatting:

* warning: include_once(./themes/engines/phptemplate/phptemplate.engine) [function.include-once]: failed to open stream: No such file or directory in C:\Program Files\Apache Group\Apache2\htdocs\includes\theme.inc on line 78.
* warning: include_once() [function.include]: Failed opening './themes/engines/phptemplate/phptemplate.engine' for inclusion (include_path='.;C:\php5\pear') in C:\Program Files\Apache Group\Apache2\htdocs\includes\theme.inc on line 78.

Also, if I logout and click on top24h, I get Google Ads pages appearing below the header.

Will try a fresh installation, and perhaps your prepackaged installation, and let you know how it goes. In the meantime, happy new year!

mercmobily’s picture

Hi,

@Wotstheguts:
Do you still have problems with the final release, wotstheguts? If so, which browser are you using precisely? Do you have the same problems on http://www.drigg.org or http://www.fsdaily.com?

@japan_san:
The issue is definitely there, we are investigating it.

Merc.

wayout’s picture

StatusFileSize
new54.55 KB

I am also getting a bug when submitting a story. I managed to submit 1 story. I then changed the name of the categories. I now get a red box around Story's Title and Story's Description. The error box appears but with no message inside it. please see screenshot.

mercmobily’s picture

Status: Active » Closed (fixed)

Hi,

This bug got too messy. Everybody: if you have new bugs, please submit new bugs. The original poster posted a very clear problem, but now it's really hard to figure out what is going on here.

@wayout: there is a simple answer to your question. However, I will not pollute this bug with it. Feel free to submit a new support request.

@wotstheguts: while writing in a bug about Javascript, writing "I also get the following error when I click on the "newest" link, and lose the theme formatting: [...] " won't help. I will ignore this.

I fixed the error of the "empty error messages" in the latest drigg-distr.tgz - believe it or not, *I* was using the wrong version of jquery.

@ japan_san: can you please confirm that the latest version of drigg-distr.tgz and Drigg have the same problem?

Bye,

Merc.

mercmobily’s picture

Status: Closed (fixed) » Active

Hi,

I had closed this by accident. Reopening it.

Merc.

japan_san’s picture

Hi Merc.

I tested submit story on Drigg.org and when I left field Tags empty I could submit story.
Then I tested last version of drigg-distr.tgz on my local instalation, but behaviour was same like in my first post.

nigelTheBold’s picture

StatusFileSize
new9.17 KB

Hello, everybody,

The javascript has been fixed, and the file is attached for your testing pleasure. Please let me know if there are still submit issues.

mercmobily’s picture

Hi nigelTheBold,

Thanks for the patch!
However... I can see two very dangerous assumptions:

* The patch seems to assume that the tid for the categories will be 1, and the tid for the tags will be 2. Now... I think it's a _little_ too much to assume

* The patch assumes that no another module will introduce extra validation.

I think a better way to go about it is to separate Drigg's CSS classes from Drupal's. So, we add the class "error-drigg" rather than error, AND change the CSS so that it renders them similarly (identically?) to the error class.

This means that if Drupal sets "error" (and of course it sets it forever, since it's a page load), the javascript won't care.

Do you know what I mean?

Bye,

Merc.

nigelTheBold’s picture

StatusFileSize
new7.94 KB

Hey, Merc, everyone,

Here's a better patch. There are fewer assumptions, as now it only takes responsibility for the Drigg fields. The other node fields (tags, taxonomy, etc) aren't checked before submission.

This makes error handling a little inconsistent, of course. Any non-Drigg error will *not* clear during data entry, as the Drigg fields do. I doubt this will be too confusing to the end-user, but it is a potential point of confusion.

mercmobily’s picture

Hi,

Can everybody here confirm that the new drigg.js file fixes the problems?

If it does, Drigg will have no open bug reports and I can finally start with feature requests.

Bye,

Merc.

lhd333’s picture

I'd test it, but I don't know where to overwrite with that patch. (I DO overwrite the file correct?)

So where is drigg.js_.txt located?

mercmobily’s picture

Hi,
The file drigg.js_.txt should be renamed drigg.js and placed in sites/all/modules/drigg, OVERWRITING the old drigg.js.

While testing, please please please make absolute sure you clear your browser's cache -- javascript files are aggressively cached by the browser.

Bye!

Merc.

mercmobily’s picture

Status: Active » Fixed

Since I tested this patch and it seems to be working 1000%, rolling it out and releasing it along with Drigg 1.6 and drigg-distr.tgz

japan_san’s picture

So I tested last release of drigg-distr.tgz on my local instalation and it works OK.
Thanks, good work.

mercmobily’s picture

Status: Fixed » Closed (fixed)
dbonchabo’s picture

StatusFileSize
new5.47 KB

I still get an error with drigg 6x When i paste a link into the scoop's url field there is a red border around that field with no indication what the error might be