Better URLs: avoid underscore and separate out "delete"
HorsePunchKid - December 25, 2007 - 01:43
| Project: | Path Redirect |
| Component: | Code |
| Category: | feature request |
| Priority: | minor |
| Assigned: | HorsePunchKid |
| Status: | closed |
Description
In brief, does it make sense to have:
http://example.com/admin/build/path-redirect
...rather than:
http://example.com/admin/build/path_redirect
...and:
http://example.com/admin/build/path-redirect/add
...instead of:
http://example.com/admin/build/path-redirect/new
...and:
http://example.com/admin/build/path-redirect/delete/314
...as opposed to:
http://example.com/admin/build/path-redirect/edit/314/delete
The latter two changes I have already made for the D6 branch while doing the conversion; it just seemed like the more standard way. I can whip patches shortly. Is this likely to break existing links? (For example, does the new pathauto integration rely on the URL in anyway, or just the API?)
#1
Here's a patch which does the above. It also separates out the admin overview function from the add/edit form preparation, and it cleans up a couple of other tiny issues which should be clear if you skim the patch.
I'll test this a little more, and I'll probably commit it soon if there are no objections.
#2
I think I need to do an update to clear the menu cache after making this change.
#3
Tested with and without clean URLs on MySQL and Postgres; upgrade worked fine, everything looks good. Committed!
I need to check how this matches up with the 6.x branch now...
#4
I applied the necessary parts of this patch to the 6.x branch.
#5
Automatically closed -- issue fixed for two weeks with no activity.