When advanced action is deleted first, trigger cannot unassign. Please confirm it.

steps:

  • create own advanced action at admin/settings/actions
  • assign trigger to created action at admin/build/trigger/node
  • delete that action at admin/settings/actions
CommentFileSizeAuthor
#4 trigger-remove.patch699 bytesgábor hojtsy
#2 Screenshot_2.png8.42 KBgábor hojtsy
#2 Screenshot_3.png16.1 KBgábor hojtsy

Comments

Takafumi’s picture

Takafumi commented
Priority: Normal » Critical

Encounters WSOD at triggered event when orphaned trigger remains. For this reason, this issue is critical.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: When advanced action is deleted first, trigger cannot unassign » Advanced actions should be deassigned before deleted
StatusFileSize
new Screenshot_3.png16.1 KB
new Screenshot_2.png8.42 KB

I can reproduce this issue. The problem is that when you remove an advanced action, it is not deassigned first from all triggers. This results in these interesting admin and delete confirm pages as attached.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Why does this happen?

- When you delete an action, system_actions_delete_form_submit() is invoked.
- This invokes actions_delete($aid), which deletes the action.
- actions_delete($aid) also does a module_invoke_all('actions_delete', $aid); call, which is supposed to be used by modules to react on the deletion
- trigger module does not implement this hook, but it should implement it to remove all trigger associations for this action as well

That's our problem.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Advanced actions should be deassigned before deleted » Advanced actions should be deassigned when deleted
Status: Active » Needs review
StatusFileSize
new trigger-remove.patch699 bytes

Patch cooked, tested, works for me.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Note that aid is a varchar column, so we need to use this string check. It is not a usual integer ID.

Takafumi’s picture

Takafumi commented
Status: Needs review » Reviewed & tested by the community

Great, a patch works properly.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks for testing.

Takafumi’s picture

Takafumi commented
Status: Fixed » Closed (fixed)

thanks.