It leads to an infinite loop. Easy fix.

CommentFileSizeAuthor
#2 recursions-warning-204083-1.patch1.26 KBpwolanin
menu_f2.patch1.08 KBchx

Comments

chx’s picture

chx commented
Status: Needs review » Closed (won't fix)

but wrong. you get $map already, use that, case closed.

pwolanin’s picture

pwolanin commented
Priority: Critical » Normal
Status: Closed (won't fix) » Needs review
StatusFileSize
new recursions-warning-204083-1.patch1.26 KB

agreed, since even protecting against the recursion leaves non-functional code in some cases. A simpler approach to consider - we should at least document the potential problems in the doxygen for this and menu_link_load().

pwolanin’s picture

pwolanin commented
chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

This is a fine change.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.