Fatal error when machine readable name for content type set to "theme"

I am fairly sure you can screw up with even more interesting content type names.

chx: That makes it worse not better.
Should imho be generically fixed at least for D6, so we don't get code-data conflicts like this again and again in subsequent API changes.

The fault is with the node system. The documentation for drupal_get_form() says

If a function with that name exists, it is called to build the form array.

The node system cannot ignore that.

The patch changes the form_ids of node forms to 'node_' . $type . '_node_form'. This is only a temporary solution. Potentially conflicting functions do not exist in core, they can only come from contrib modules (which is an improvement).

No way this can happen for Drupal 6...

Where do you see problems with the patch?

"Theme" is not that far fetched a name for a node type; think of theme gallaries. This issue is even on the edge of being critical; it should definitly be fixed. Do you know of any contrib modules that get broken by the patch?

seems to be more or less the same issue as: http://drupal.org/node/204415

It is not.

• #204415 is caused by the node system using the menu system in a wrong way.
• #204119 is caused by the node system using the forms system in a wrong way.

I marked this as critical. Reasons are

1. The user gets an empty page or a raw PHP message upon an error.
2. The error is not obvious when creating the type, but rather when creating content of that type. Creating content is done by possibly inexperienced users.
3. I see hook_form_alter() as the main reason for my patch to be regarded as an API change. However
   • the documentation of hook_form_alter() suggests $form['#node']->type to check the type of the node
   • the documentation of node_forms() does not guarantee a specific value of the $form_id parameter,
   • $form['#id'] == 'node-form' in any case.

Critical is when many people's sites are broken. This affects few people and the site is site is still operational.

An earlier patch proposed at http://drupal.org/node/204415 (wisely by chx) would blacklist "theme" as a content-type.

That's why I linked ot it.

Indeed, we can blacklist some types for now, and postpone any API changes to Drupal 7.
Moving the discussion to http://drupal.org/node/204415

#204415: Creating content types 'add', 'theme', 'list' (and possibly others) causes various problems is fixed.