Add SimpleTest tests to CustomError module

geodaniel - December 27, 2007 - 19:19
Project:CustomError
Version:5.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

I've started putting some work into creating some SimpleTest tests for the CustomError module. Attached is a patch for the module which implements hook_simpletest() and an initial test which simply tests that the 404 message is returned when expected. The test file should be renamed to pagenotfound.test and placed into a tests directory in the customerror directory.

AttachmentSize
pagenotfound.txt1.94 KB
customerror_simpletest.patch719 bytes

#1

geodaniel - December 27, 2007 - 19:26

Cleaning up spacing in test file.

AttachmentSize
pagenotfound.txt1.96 KB

#2

kbahey - December 27, 2007 - 20:13
Status:patch (code needs review)» fixed

Committed to HEAD and 5.x.

#3

geodaniel - December 27, 2007 - 20:48

Thanks Khalid

#4

geodaniel - December 28, 2007 - 11:10
Status:fixed» patch (code needs review)

Attaching a patch to fix up the page not found test (spacing and also adding a user login so that we're not relying on the anonymous user having access content privileges) and also adding a test for access denied.

AttachmentSize
accessdenied.test_.txt1.92 KB
pagenotfound.patch3.6 KB

#5

kbahey - December 28, 2007 - 15:04
Status:patch (code needs review)» fixed

Committed to HEAD and 5.x.

Please do not reopen fixed issue for new features. Create a new one.

#6

geodaniel - December 28, 2007 - 15:56

Thanks, I will do that in the future.

#7

Anonymous - January 11, 2008 - 16:01
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.