Found another PHP 4 vs 5 incompatibility. I tried running the sample code from here:
http://drupal.org/node/193601

And I got this error:
warning: uniqid() expects at least 1 parameter, 0 given in C:\Inetpub\wwwroot\raft3_alpha3\modules\open_flash_chart_api\open_flash_chart_api.module on line 86.

I changed line 86 from:
$this->unique_id = uniqid();

to:
$this->unique_id = uniqid(rand(), true);

That's a slightly better implementation, I think, and will work in both PHP 4 & 5.

I'd submit a patch but, honestly, I don't know how. So I'll leave that to our maintainer's skilled hands.

BTW, Cool module!

Comments

redndahead’s picture

Status: Active » Fixed

Sorry for the long delay. This has been fixed in CVS. For some reason I'm having issues releasing 5.x-dev so you will have to obtain from CVS until I make a release.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.