Closed (works as designed)
Project:
Extra Voting Forms
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2007 at 10:56 UTC
Updated:
13 Jul 2008 at 00:28 UTC
I was wondering if you could define what features of jQuery 1.2.x are being used in this and the other modules tied to the Drigg project as currently there is not a smooth upgrade path to jQuery 1.2.x via the jQuery Update module.
jQuery Update brings jQuery in Drupal up to 1.1.2 or 1.1.3 I can't recall which. If you could layout what features of jQuery you are using that require the use of jQuery 1.2.x perhaps the community could help you to refactor the .js to be compatible with jQuery 1.0.x or 1.1.x.
I think the Drigg related modules could be quite useful but the jQuery 1.2.x requirement makes the hurdle a bit higher than otherwise.
Comments
Comment #1
mercmobily commentedHi,
OK, we are investigating this one right now.
I am really concerned about breaking cross-browser compatibility.
It took us countless hours to make sure that everything worked with this version of JQuery. It was my mistake: I thought that this version was what came with jquery_update... silly me.
We are looking into it. I don't kow Javascript... so, Anthony is dealing with this one.
Bye!
Merc.
Comment #2
kpaul commentedany updates?
many thanks.
Comment #3
mercmobily commentedHi,
Not yet - sorry.
Anthony was going to work on it over the week-end. However, something happened in his personal life and he didn't have time.
This is one of the REALLY HIGH PRIORITY things in Drigg right now. So, if it's possible, it's gonna be done soon.
Bye!
Merc,
Comment #4
bobdalob commentedThis one perplexes me as I don't have any issues with running this module and jquery 1.21 WITH jquery_update. Without the jquery_update fixes, there are of course some broken elements however I have encountered no adverse effects with this method.
It's possible I'm missing something (it's very possible as I'm an expert in NO field here!), in which case please help by telling me, but this method allows me to run this module and thickbox and several others that rely on any version of jquery, without any issues that I have seen.
Comment #5
kpaul commentedWhen I use the newer/newest jquery, it messes up TinyMCE... or it was last I tried...
Comment #6
mercmobily commentedHi,
Can we research this issue a little?
We at Drigg might end up spending a LOT of time trying to figure out how to make extra_voting_forms work with an old version of JQuery... but in the end, that might end up being a waste of time!
Can you please let me know what _definitely_ breaks by using jquery 1.2.1? Also, I noticed that jquery_update gives out a CSS which if included actually fixes a lot of problems with Drupal itself. Can you tell me precisely which file you need, and if that's OK to just include it in page.tpl.php?
Thanks!
Merc.
Comment #7
mercmobily commentedHi,
Alright I ended up doing the research in the end.
While we _could_ change the module so that it works with an older version of JQuery, there is the Drupal 6 issue, which will indeed come with JQuery 1.2.1.
So, there is no real point in downgrading Drigg. Any extra things like the TinyMCE will have the same issues in Drupal 6. So...
HOWEVER, the glitches are indeed annoying. So, I:
* Updated drigg-distr.tgz so that it includes those fixes.
* Updated the theme so that includes those fixes
* Updated the instructions so that people will know that they need the extra js files
This will close the issue, which will disappear completely in Drupal 6.
Bye!
Merc.
Comment #8
2c commentedI've come up with a solution that works for my particular problem.
Basically, I need extra_forms functionality on my content, when a person views that content.
I need hierarchical select functionality when a user creates new content or edits new content.
These two modules use different versions of jQuery.
I set up my site to use jQuery 1.1.2. Then, I copy jQuery 1.21 into my misc folder, but give it a name of jQuery-12.js Do not overwrite the existing jQuery.js file.
Then, open up extra_voting_forms.module and around line 80 replace the lines:
With the following:
This code basically says: Once the current node isn't being edited or added then include jQuery-12.js.
If you view the source code of an html page with an extra_forms_widget you will see that both jquery.js and jQuery-12.js are being included. jQuery-12.js is included after jquery.js and so it is overriding the functions defined there...I think.
If you find the module that is including the original jquery.js file then you could write in a condition that is basically the reverse of the snippet I gave above for jQuery-12.js (or maybe Drupal has an in-built function that will tell if a certain js file has already been included?). This would save your server from calling an unneeded file.
As I said, this code works for a very particular scenario, but it might help some people out.
Comment #9
dorien commentedWould be great to be able to use jquery update. So many modules are using it...
Jquery update just got a new maintainer and started on a 2.x version (backwards compatible), looks like we can use that one with Drigg soon...
Comment #10
mercmobily commentedHi,
Drupal 6.x comes with the right version of JQuery. So, there will be no need to use external modules.
Till then, we'll suffer.
Merc.
Comment #11
blooksllc commentedHi all,
I wanted to share a solution that I found to making everything (I have installed) work with jquery 1.2. I installed the http://drupal.org/project/jquery_update module, activated the module, and copied the jquery.js file provided with extra voting forms into sites/all/modules/jquery_update. This fixed the collapse problems I was having.
Ted
Comment #12
kulfi commentedhttp://drupal.org/project/jquery_update should be added as a required dependency.
Comment #13
mercmobily commentedHi,
It's tricky. Drigg doesn't really work with the JQuery module that comes with jquery_update. People can "steal" files from there in order to fix the collapsing problem, but...
I wouldn't make it a requirement for this.
Merc.