I'm running into problems with workflow_tab_form_submit calling node_save.

1) it triggers hook_nodeapi($node, 'update' ...), implying to other modules that the node itself (as opposed to its workflow status) has changed. This may or may not be what you want; in my case it isn't. I was hitting compatibility problems with pathauto, but the latest rev of pathauto seems to have fixed. But it also means that modules like subscriptions can't distinguish between a revised node and a workflow change.

2) it touches the node's revision date in node_revisions; also may or may not not be what you want.

It's an easy fix: abstract the code under the 'insert' switch into a separate function and call that from workflow_tab_form_submit instead of node_save. But that may break other modules. Either way, I thought you should have this.

Thanks for a great module!

CommentFileSizeAuthor
workflow.patch2.6 KBtherzog

Comments

rconstantine’s picture

rconstantine commented
Version: 5.x-1.1 » 6.x-1.5

I'm having issues with this too. I think this may be the cause of these problems: http://drupal.org/node/1013768

Unfortunately, I don't think the above patch applies to 6.x. The code seems to have migrated too far.

Bastlynn’s picture

Bastlynn commented
Status: Active » Closed (duplicate)

This has been addressed now on 6.x-dev branch and will be live with the next release in issue #1471014: Submitting workflow tab form clobbers current revision details. 5.x is a depr. version of Drupal (you really should update if you're still on 5!) that at this point we can't really support that far back. But for 6 and 7 at least, this is fixed up.