Closed (fixed)
Project:
Views Bookmark
Version:
5.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Dec 2007 at 21:54 UTC
Updated:
20 Jan 2008 at 20:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
zig007 commentedHere is my suggestion for a views_bookmark.install that installs(and uninstalls) the module on PostgreSQL as well.
I have just tried it a couple of times and ways, and it seems to work.
However i have just started testing the component functionality, and so far i haven't gotten that long, for some reason i don't get an interface at "Administer -> Site Building -> Views bookmarks (/admin/build/views_bookmarks)", as stated in the README.txt.
But I guess that'll sort itself out.
Comment #2
mooffie commentedHere's a patch. It isn't zig007's but mine (I was offline so I had to write one myself).
The code creating the sample bookmark is now shared among both databases. That's so that we can easily migrate this thing to Drupal 6. For the same reason I replaced the {sequence} table handling with a simple call to db_next_id(): so we don't have to do PgSQL "magic".
(zig007's version has a 'DROP SEQUENCE' in hook_uninstall. My version doesn't, because the sequence is owned by the table, so it gets droped automatically.)
This bug was marked as 'critical' and it well deserves this status. Until this patch is commited every PgSQL user is going to waste her time writing her own installation code (see http://drupal.org/node/92850).
Comment #3
zig007 commentedGreat!
I'll try that one instead of my suggestion, I did not see the other thread you referred to, since i couldn't think of anyone calling this a non-critical bug.
Regarding the sequence, I just wanted it to have the same name as the one in the MySQL code...Don't ask me why.. :-)
Comment #4
mooffie commentedHi, Zig. Don't forget: we want to mark this issue "Ready To Be Commited", so if the patch works for you, please go on and mark it as such.
(How to apply a patch.)
Comment #5
zig007 commentedHi Mooffie,
The install/uninstall of the database elements seem to work now, which I suppose is the initial scope of this bug(marked the issue accordingly).
However, regarding the issue of the "/admin/build/views_bookmarks"-administration page not working, that was just me having to add the correct permissions to the user i was logged in as... It would be great, though, if that was mentioned in the readme, just to be sure....
Comment #6
mooffie commentedYou have a typo. The page is `.../views_bookmark', not `.../views_bookmarks'. (The singular form, not the plural. Yes, I see the README indeed has a bug in the spelling.... but that's for a separate issue)
Is that the case? Or were you actually trying to access the correct page, `.../views_bookmark' ? And when you say "i don't get an interface", do you mean you get an "access denied" message?
Don't you work as user #1?
If not, you need the "administer views bookmark" permission to be able to access admin/build/views_bookmark.
Comment #7
zig007 commentedYes, that was a typo.
No, I work as a user having an "administrative user"-role, which i created myself. It sounded good at first :-)
Comment #8
quicksketchThanks guys! I'm sure many people will appreciate the new pgSQL compatibility. The code is cleaner than before also, thanks for that. I also fixed the typo in README.txt. Thanks!
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.