Thanks for the module!

The attached patch makes the ilovethis widget themable. The reason I would like this, is that I would like to change the text in the 3 links. "I Love This" is cute, but in this case, I'd prefer to say something like "I support this." You can sortof do this with the locale module, but I've always found that kinda kludgy, and I'm not quite sure that it works right for real multi-lingual sites (as mine is).

I thought about making each of the links themable or even as settings, but I think that this is the smallest change, with the least impact, that gives complete flexibility to control the display.

CommentFileSizeAuthor
#3 204503.patch6.64 KBdouggreen
#2 204503.patch6.64 KBdouggreen
#1 204503.patch6.57 KBdouggreen
theme-ilovethis.patch3.43 KBdouggreen

Comments

douggreen’s picture

douggreen commented
StatusFileSize
new 204503.patch6.57 KB

Here's an updated patch that allows a little easier theming of the theme_ilovethis_view_table. Theme functions should mostly control output display, so I've moved some of the logic that builds the rows into the invoking function. If the theme function doesn't like the header and rows, they are still free to change them.

douggreen’s picture

douggreen commented
StatusFileSize
new 204503.patch6.64 KB

This additional change won't theme the widget or the link to all people, if the user doesn't have access.

douggreen’s picture

douggreen commented
StatusFileSize
new 204503.patch6.64 KB

doh, sorry, this patch fixes the access

douggreen’s picture

douggreen commented
Status: Needs review » Fixed

committed

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.