Closed (fixed)
Project:
Views Bulk Operations (VBO)
Version:
5.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
28 Dec 2007 at 23:23 UTC
Updated:
16 Feb 2008 at 19:29 UTC
with current HEAD, after submitting the configuration page of a configurable action, submitting and then confirming on the final page, no form data appears to be getting passed to the action.
problem does not occur in beta3 version.
Comments
Comment #1
infojunkieWe've been having problems with configurable actions and we need to coordinate better to resolve them. Specifically, I'd like the following:
* Please try my own scenario below and verify whether it works for you or not.
* Please send me a specific action that causes all the problems you are witnessing, to enable me to debug them on a real case. If your code is customer-specific, then maybe you can disable the specific features and replace them with dummy values as long as the bug is reproduced.
On my side, here's the status: All advertised features work on action "change node author" that comes with actions.module in actions.inc. That's how I've tested my code. Specifically:
* Form data is passed to the action upon submission.
* Errors in the form are correctly reported in the form by highlighting the erroneous field. To verify this behaviour, I forced the action form to display a text field instead of a drop-down with all users, by changing file actions.module/actions.inc, line 235 in function action_node_assign_owner() from
to
Comment #2
harry slaughterthis problem was introduced in views_bulk_operations.module version 1.36
you can reproduce it using the debug module i temporarily included in HEAD. enable/run one of the debug actions, and you will see that $edit has no values when the form is submitted, therefore the action fails.
Comment #3
harry slaughterOK, looks like this is a problem with my own actions not implementing the submit callback properly.
Let me confirm this before closing this ticket.
Comment #4
harry slaughterComment #5
SolomonGifford commentedI've confirmed this report. beta3 works, beta4 does not.
Comment #6
harry slaughterThis bug is not valid AFAIK. The actions that were not working were written by me, and they did not have a valid submit callback implemented.
What actions are you having problems with?
Comment #7
SolomonGifford commentedI have an action I wrote that copies the value of one cck field (or the body/title field) into another cck field. Its over two pages of code, otherwise I'd paste here. I'm pretty sure its to spec. Let me know if you'd like me to send it to you...
Comment #8
infojunkieHey solomongifford, I'm responsible for that piece of code. If you don't mind, plz send me your action by email at kratib {at} open {dash} craft {dot} com. Thanks!
Comment #9
SolomonGifford commentedWill do...
Comment #10
infojunkieClosing for lack of activity after offline email exchange.