Roles should not be separated by a BR.

Committed to HEAD.

I'm not sure how I feel about this. Removing the break is OK, I suppose, but removing the comma would not be. You could not have breaks alone, because roles can have spaces in them, and they may not break properly. So, we need to leave the commas in. Personally, I think it is nicer to see what we have now:

authenticated user,
administrator,
web site user

rather than:

authenticated user, administrator, web
site user

We probably shouldn't have the hardcoded break, but maybe they should be in a div. That way a theme can display them inline if desired.

Cross-posted with Dries there. Setting back to active, because I don't think this is the best fix.

Here's a patch that wraps each role in a div:

<code>
<div class="role">authenticated user,</div> <div class="role">foo bar,</div> <div class="role">baz blah</div>

This way they still appear on separate lines unless the theme decides to make div.class display inline.

Ugh...and the patch

I would prefer that these be spans, since they're the least semantically offensive.

If you want to have breaks, you can do so in your theme (span.user-role{display:block;}), otherwise they sit snuggly in a single line.

+1 from me.

However, were we not going to make a generlal wrapper function? Should we then not wait for that function, instead of seeding HTML all over the place?

What's interesting about your point, Ber, is that in this case, we really don't need a wrapper per se... instead, if you just threw a class on the containing TD, you could wrap the roles in spans and then style them that way:

<code>
<td class="roles">
  <span>administrator,</span>
  <span>authenticated user</span>
</td>

However, the broader question here is what should be wrapped by Drupal (and at what level of granularity -- i.e. wrap each role as in this patch or wrap the container with a class?). Furthermore, does it make sense to make this themeable or not?

At some point we're going to need to hash out how to make decisions about this kind of thing, since the BRs that were removed were not semantic and were purely presentational. I would strongly suggest erring on the side of semantic defaults that themers can manipulate to their will; the question though, is, what consistent parts of Drupal should be themeable without overcomplicating things?

Just to stir things up a bit, you could also say its a list, and define HTML and CSS to display it as desired, whether that be inline or as a block list...

Anyways, I was just checking this patch against CVS - does it still apply? I no longer see a column for roles in the table at all. It seems user_admin_account() function no longer SELECTs or displays it?

function user_admin_account() {
  $header = array(
    array('data' => t('Username'), 'field' => 'u.name'),
    array('data' => t('Status'), 'field' => 'u.status'),
    array('data' => t('Member for'), 'field' => 'u.created', 'sort' => 'desc'),
    array('data' => t('Last access'), 'field' => 'u.access'),
    t('Operations')
  );
  $sql = 'SELECT u.uid, u.name, u.status, u.created, u.access FROM {users} u WHERE uid != 0';

No longer applies to current CVS-HEAD: the "roles" column was removed in rev 1.471.