I find the documentation of db_rewrite_sql() a bit vague and propose the following changes:

-- add the {node_type} table to the list
-- clarify $primary_field
-- clarify $args as "not currently used"

Same changes also for _db_rewrite_sql(), except the third (don't know whether it applies).

If I understand this correctly, then single-node accesses should use node_access() for checking permissions. If this is correct, then adding a pointer to node_access() (and possibly vice versa) would be helpful, but I don't know how to add this properly. @see doesn't seem to work correctly.

CommentFileSizeAuthor
database.inc_.db_rewrite_sql.doc_.patch1.99 KBsalvis

Comments

dpearcefl’s picture

Status: Needs work » Postponed (maintainer needs more info)

Does this issue exist in current D6?

salvis’s picture

Yes, the issue still exists, but no one cares about it anymore.

Feel free to close it.

Thanks for going through all those old issues!

dpearcefl’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)

So let it be written. So let it be done.