I try many times. Add image node, upload image and both, thumb and image don't have watermark.
I put the watermark png in the drupal root and watchdog its ok, no errors.

I try in new drupal too, with only image and watermark module.

thanks

CommentFileSizeAuthor
#12 watermark.patch37.24 KBsgriffin
#7 watermark.module.txt17.77 KBWounded Knee
#2 Screenshot.jpg51.06 KBWounded Knee
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

VM’s picture

VM CreditAttribution: VM commented

are you sure you have the settings properly set in administer -> water mark ?

Wounded Knee’s picture

Wounded Knee CreditAttribution: Wounded Knee commented
FileSize
Screenshot.jpg51.06 KB

yes, see screenshot

VM’s picture

VM CreditAttribution: VM commented

where exactly is the watermark.png file, according to your settings, you have it in the root of your drupal install.

it should probably be in files/watermark/watermark.png, and the setting adjusted accordingly.

Wounded Knee’s picture

Wounded Knee CreditAttribution: Wounded Knee commented

nothing :(

I copy the png at files/watermark/ and update settings.

thanks

Wounded Knee’s picture

Wounded Knee CreditAttribution: Wounded Knee commented

I tried all, I need put my head in the fridge

Wounded Knee’s picture

Wounded Knee CreditAttribution: Wounded Knee commented

More info:
In drupal 4.7 it works

In Drupal 5.5 not:
with image-5.x-1.0 to last

I see in watermark.module:

function watermark_form_alter($form_id, &$form) {
  // additional option to toggle watermark process when a user has "manage watermarks" permission
  if ($form_id == 'image_node_form' && user_access(WATERMARK_PERM_MANAGE)) {
    $apply_watermark = true;

    if (preg_match('/^\/node\/[0-9]+\/edit$/i', $form['#action'])) {
      $apply_watermark = false;
    }
    else if ($form['#action'] != '/node/add/image') {
      return;
    }

    $form['watermark'] = array(
      '#type' => 'fieldset',
      '#title' => t('Watermark settings'),
      '#collapsible' => true,
      '#collapsed' => false,
    );
    $form['watermark']['wm_apply'] = array(
      '#title' => t('Apply watermark'),
      '#type' => 'checkbox',
      '#description' => t('<strong>Automatic watermark process bypass:</strong> Please decide yourself if a watermark needs to be applied. <strong>Be careful, do not apply watermarks twice!</strong>'),
      '#default_value' => $apply_watermark,
    );
  }
}

BUT I never seen this option in /node/add/image
also 'Apply watermark', 'Watermark settings', 'Automatic watermark process bypass: Please decide yourself if a watermark needs to be applied. Be careful, do not apply watermarks twice!'... don't exist in settings/locale

cheers

Wounded Knee’s picture

Wounded Knee CreditAttribution: Wounded Knee commented
Status: Needs work » Active
FileSize
watermark.module.txt17.77 KB

Finally works, with this code: Watermark 5.x-1.0-alpha1 + Watermark language issue + some change
http://drupal.org/files/issues/watermark.tar_.gz http://drupal.org/node/198826

I delete "additional option to toggle watermark process when a user has "manage watermarks" permission", because don't works for me.

Edit: attach file. sorry for paste all code.

kbahey’s picture

kbahey CreditAttribution: kbahey commented
Status: Active » Needs work

Please do not paste entire modules in the issue. A few lines is OK, but entire modules is not.

Also, create a patch, then others can test it, and if confirmed, I will commit it.

See http://drupal.org/patch on how to create patches.

sgriffin’s picture

sgriffin CreditAttribution: sgriffin commented
Status: Active » Needs work

Was this patch ever rolled in? watermark does not appear to be compatible with image 5.x-2.0-alpha3, gd, and/or php 5.
Versions dev or head.
Hacked version works on only original but not on rebuilt derivate images, or other image presets.

sgriffin’s picture

sgriffin CreditAttribution: sgriffin commented

thanks wounded knee, I was finally able to get watermark to work by checking an odd phantom preset called "_original" in the watermark module, by using your updated module, and replacing function _watermark_is_node_excluded with the latest version, otherwise, it generates for each errors.

kbahey’s picture

kbahey CreditAttribution: kbahey commented

sgriffin

Can you please create a patch for what worked for you so I commit it and everyone gets teh fix? Please create the patch using http://drupal.org/patch against the latest version with the DRUPAL-5 tag.

sgriffin’s picture

sgriffin CreditAttribution: sgriffin commented
FileSize
watermark.patch37.24 KB

Not sure if this patch is very pretty, in fact I am sure.
But I do not program really.
The changes I made are exactly as described in #10. I used http://drupal.org/files/issues/watermark.tar_.gz and replaced function _watermark_is_node_excluded with the one in the dev version.

Not sure if this helps, but the site I am working on is not live and is installed in a subdirectory, could be the reason why the dev or head versions do not work. I didn't check into the differences from woundedknee.

kbahey’s picture

kbahey CreditAttribution: kbahey commented

The patch has too many changes, even if I ignore white space. So it is against an older version of the module, and would overwrite other stuff in it if applied as is.

If you or anyone can provide a patch with just the change that fixes the issues, I will happily review and commit it.

sgriffin’s picture

sgriffin CreditAttribution: sgriffin commented

I am not sure what all the issues are, this is based on the problems occurred from december 2007. These bug fixes may not have been rolled in since then which is why there are so many changes.
My post was just FYI for this modules maintainer, so future users will know which code fork to use.
Its also possible, that the head or dev version of watermark works as is, but against what versions of dependent modules, I don't know either.

sgriffin’s picture

sgriffin CreditAttribution: sgriffin commented

It is also possible to use imagecache actions to watermark. There is added functionality in that you can affect all previously uploaded images.
This is done with imagecache_image.module, and imagecache canvas actions and image of course.