Default subjects like 'Re: Parent's subject' and a bit of code cleanup [#20477]

Emails containing a comment's contents, such as those listhandler sends, are particularly unfriendly because the default subject line, which is often not changed, is quite arbitrary. Using 'Re: parent's subject' is a bit better.

I did a bit of code cleanup around the lines I changed as well.

Comment	File	Size	Author
	comment.module_11.diff	3.9 KB	drumm

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Steven CreditAttribution: Steven commented 15 April 2005 at 15:15

I thought the consensus was that Re subjects were evil? "Re" serves to indicate which message replies to what in emails. With threaded support in mail clients that's now becoming obsolete too, but in Drupal I see no need whatsoever to imitate this bad practice.

This line:
$edit['subject'] = truncate_utf8(decode_entities(strip_tags(check_output($edit['comment'], $edit['format']))), 29, TRUE);

is the result of a long discussion about comment subject autogeneration. In light of various input formats, mandatory / disallowed subjects, this seemed like the best idea.

Comment #2

factoryjoe CreditAttribution: factoryjoe commented 18 April 2005 at 21:57

I think I want to +1 this, but I also think that the extra clutter in the web UI would be distracting. I think that comment titles should be optional -- and the email notifications that go out w/o a subject should grab the parent's subject like Drumm has done. So the real difference that I'm suggesting here is to allow for titleless comments, since people often write title-less comments anyway. Forcing a title only helps w/ email integration.

Chris