Themeable profile list patch for profile.module

looka useful ... please provide unified diff format. as per http://drupal.org/handbook

It doesn't really look suitable for theming, though, due to all the database logic. To make this really a theme function, you'd have to prepare the data into some variables that you can get by calling function A, and make a theme function B that outputs the variables.

Things that can't be in theme functions include SQL and user access logic.

Hi,

This is a patch providing the same thing, but without taking the database code into the theme_profile_list function. I've had this running on one of my sites for a while and found it necessary to output a table listing member contact details (note: there aren't many profile fields accessible by anonymous users in that example, but you get the idea). Unfortunately I never got around to separating it from my other profile.module modifications until now.

Let me know what you think.

Cheers,
Eric

Patch doesn't apply any more.

Moving to 6.x-dev queue. There is a theme_profile_listing() function in HEAD now, but it doesn't seem to theme the whole list of users, just individual users... so this issue is probably still relevant.

Unassigning from vfilby - user doesn't seem to have been active for some time on drupal.org.

Profile module now has tpl.php file for the profile listing.

Add SQL "ORDER BY" in db_query sentence inside function profile_load_profile().

Old query:
$result = db_query('SELECT f.name, f.type, v.value FROM {profile_fields} f INNER JOIN {profile_values} v ON f.fid = v.fid WHERE uid = %d', $user->uid);

New query:
$result = db_query('SELECT f.name, f.type, v.value FROM {profile_fields} f INNER JOIN {profile_values} v ON f.fid = v.fid WHERE uid = %d ORDER BY f.weight ASC', $user->uid);

jmav. Please open a new issue at http://drupal.org/node/add/project-issue/drupal instead of re-opening this one. This function hasn't changed since 4.6 and is not related to this discussion.

Sorry my mistake, can you delete my issue in this treat?

New issue is http://drupal.org/node/206124

Nope, issue comments cannot be deleted. But nevermind, we just set the settings back, and everything's fine!