comparing a uid to nid is fun but won't lead to anything good, i guess.

Edit: I am writing a simpletest. Again and again and again, write those and you will rewarded richly with bugs.

CommentFileSizeAuthor
#3 poll_notice_followup.patch614 byteschx
#1 poll_opsie.patch1.5 KBchx
poll_opsie.patch1.33 KBchx

Comments

chx’s picture

chx commented
StatusFileSize
new poll_opsie.patch1.5 KB

Better patchy. Note that I am fixing notices wherever I find them.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Good catch! Committed to CVS HEAD.

chx’s picture

chx commented
Title: Poll access check is braindead » Poll notice fix changed behaviour
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new poll_notice_followup.patch614 bytes

I am so sorry. An unset array index is NULL not 0. And though 0 is more adequate here but that's not what the original code did and past RC it's not nice to change behaviour. But now the simpletest is working so I do not expect further trouble.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Checked the poll bar default value, and it should indeed be NULL here. Thanks, committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.