Closed (fixed)
Project:
Drush
Version:
8.x-6.x-dev
Component:
Core Commands
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Jul 2013 at 08:25 UTC
Updated:
12 Aug 2013 at 14:51 UTC
Jump to comment: Most recent file
Comments
Comment #1
Darren Shelley commentedPatch attached to add error reporting, please review.
Thankyou
Comment #1.0
Darren Shelley commentedimprove english
Comment #2
moshe weitzman commentedTechnically, that should go in a validate hook in the same file. See docs/drush.api.php
Comment #3
Darren Shelley commentedThank you for the advice, I have reviewed the API documentation and revised the patch.
The patch now provides a validation callback for site-set.
The error message has been written more generically and in line with existing standards to provide easier scope for translation in the future.
Comment #4
Darren Shelley commentedComment #5
greg.1.anderson commentedThis looks fine to me. I wonder if we should consider a general feature in command.inc to support "php function dependencies" to go with "drush dependencies" and "drupal dependencies"? Could be a follow-on issue.
Comment #6
moshe weitzman commentedCommitted to 5 and 6. Thanks.
Comment #7.0
(not verified) commentedenhance bug report, explain the end result of the function not just the output via cli