Hello everybody

I have solved the problem of white spaces, using tables. (you can see it in www.yawag.org)

If we use this "page.tpl.php" we'll have borders in the tables, so we have to edit style.css and change border: 1px to border: 0px ... someting like this:
-------------------------------------------------------
/**/
/* ---- patched no border ----- */
.main-content table {
width: 99%; /* needed for IE */
overflow: scroll;
border: 0px solid #BDCEE1;
padding: 0;
margin: 0;
margin-bottom: 1.0em;
}
td, th, .main-content td {
border: 0px solid #BDCEE1;
padding: 2px;
margin: 0;
vertical-align: top;
}
.main-content th {
border: 0;
border-bottom: 0px solid #BDCEE1;
padding: 2px;
text-align: center;
vertical-align: middle;
}
/* ---- patched no border ----- */

-------------------------------------------------------

I attach the code of page.tpl.php

admin(at)yawag(dot)org

Comments

TDobes’s picture

1. Please attach patches, not whole files
2. I think the goal was to solve the problem without using tables. I'm not sure the creator of the theme would like the idea... although, in practice, it would solve the problem.
3. Please do not post duplicate issues. This is a duplicate of bug #17844... please post all suggestions / follow ups there.

factoryjoe’s picture

Assigned: Unassigned » factoryjoe

This is not a plausible solution given TDobes’ reply that it uses a a non-semantic table. Given this, you might as well use tables for the columns as well, and that defeats the whole purpose of the layout styles!

Rest assured, I am trying to come up with a robust solution to this problem; when I released the theme, I had half-forgotten why I put off releasing it for so long and then I remember this problem…. So while I was half-hoping someone might beat me to a semantic and accessible solution, it seems I might have stumbled upon my own inadvertently in redesigning the CivicSpace website.

Carlos Miranda Levy’s picture

Status: Closed (duplicate) » Fixed

If it works, so be it.

Most of us are not out here to make a statement for non-semantic tables or the holy quest of an 100% CSS based theme.

We would just love to get the damn thing to work both on Mozilla and IE.

And it is very frustrating to put days into fixing something just to discover something else stops working.

On most of my sites, I ended using the pushbutton php template as the base because I could fix it and make it work (too bad it's not out there as a phptemplate for 4.6).

Although it's nice to upload the page.tpl.php, please indicate for what version you did this so we don't have additional problems using it with the wrong version of the templates.

Patches are a great thing for those who can patch ;-)
(I have yet to find someone who has been able to patch a Drupal file on a Microsoft machine -- all my attempts have gone bust).

Carlos Miranda Levy’s picture

Version: 4.5.x-1.x-dev » 4.6.x-1.x-dev
StatusFileSize
new7.49 KB

This has been the only solution that has completely worked for me.
Even better, it does not require any changes to files other than the theme site files.

I downloaded a fresh copy of the SpredFirefox theme at http://drupal.org/project/spreadfirefox

Release 4.6.0, 15/04/2005 - 23:15 it is.

And then added a single table, with 3 columns to fix the problem to the page.tpl.php and change border to 0 for the table style of the content id in style.css

That's it. Problem solved without messing around with any file in the Drupal distribution. Just a couple of small changes in those two files of the theme.

I'm uploading my updated files in a zip file in case anyone wants to use them or anyone is kind enough to turn them into a patch.

I know, many of you don't want to hear the word table, I didn't either. But believe me it's completely transparent to the layout, programming, functionality, etc. and the final result is what you expect.

I spent the entire weekend trying to come up with another solution, but this is the only

Note that these files are for Release 4.6.0, 15/04/2005 - 23:15 of the SpredFirefox theme at http://drupal.org/project/spreadfirefox

Cheers.

green monkey’s picture

Thanks Joe,
I knew you wouldn't rest until you got that white space bug nailed down. This is my favorite theme. I feel it is the most professional looking 3 column theme here.

I have this fantasy that one day, one of my websites might actually make money, and I would be able to sponsor a theme competition. Right now, I can't even afford mouse food and the silly mouse is plastic.

I Thank you and KB for a great theme.

green monkey’s picture

Carlos, sorry - thanks got the name wrong - thanks it workds great! and the zip file made it a snap to update.

Carlos Miranda Levy’s picture

Just noticed that with my above fix the view/edit/track tabs don't show for users on their articles on Internet Explorer.

The fix was to remove class="centercolumn" from the td I introduced back as a

(and closing it just before the

). Problem is that layout.css defines margins for centercolumn class, so had to edit layout.css to comment margin-right: 160px; margin-left: 150px; for centercolumn (twice).

So here are the updated files: page.tpl.php is changed, layout.css is introduced to the zip and style.css remains unchanged from the fix I posted before.

Anonymous’s picture

steveparks’s picture

Version: 4.6.x-1.x-dev »

Hi

I'm a bit of a novice, so forgive me if I'm not submitting this info in the right way, but I think this is the table-less solution to the whitespace problem.

Edit misc/drupal.css.

Find the following section, and comment out lines as shown:

.more-link {
  text-align: right;
}
.node-form .form-text {
  display: block;
/*  width: 95%;*/
}
/*
.node-form .standard {
  clear: both;
}
*/
.node-form textarea {
  display: block;
/*  width: 95%; */
}
* html .node-form fieldset {
/* Note: IE-only CSS due to "* html" escape. Sadly required for fieldsets to appear correctly. */
  display: inline;
}
.node-form .admin .form-item .title {
  margin-top: 0;
}
.node-form .admin .authored .form-item {
  margin-bottom: 1.1em;
}
.node-form .admin .authored .form-text  {
  width: auto;
}
/*
.node-form .admin .authored, .node-form .admin .options, .node-form .admin .extra {
  float: left;
  margin-right: 2em;
  margin-bottom: 1em;
}
.node-form .attachments fieldset {
  float: none;
  display: block;
}
*/
.ok {
  color: #080;
}
#pager {
  clear: both;
  text-align: center;
}

That seems to have done the trick for me!

Hope it helps others

cheers
steve

Anonymous’s picture

Anonymous’s picture

In Extremo’s picture

Title: white space problem SOLVED » white space problem -theme is not valid

with the patch from carlos the theme is not any longer Valid XHTML 1.0 Strict.

Anonymous’s picture

Status: Fixed » Closed (fixed)