I love this module. And it works as far as turning on modules in the other sites but I continuously get this error on Drupal 5.5 (new multi-site install):

* warning: Missing argument 1 for rollout_apply_settings() in /home/virtual/site1/fst/var/www/html/sites/all/modules/rollout/rollout.module on line 48.
* warning: Missing argument 2 for rollout_apply_settings() in /home/virtual/site1/fst/var/www/html/sites/all/modules/rollout/rollout.module on line 48.
* warning: array_keys() [function.array-keys]: The first argument should be an array in /home/virtual/site1/fst/var/www/html/sites/all/modules/rollout/rollout.module on line 62.

Comments

obsidiandesign’s picture

Category: bug » support

I can confirm the bug. It seems that the issue on line 48 is the definition of the function itself:

function rollout_apply_settings($form_id, $form_values){

I can't figure out where this function is getting called from (outside rollout.module?) but $form_id is not set and $form_values is not set. Specifying a default value:

 function rollout_apply_settings($form_id="", $form_values=""){

Makes the error go away, but doesn't seem to fix the problem on line 62. The comment before the function is also interesting: // Not too sure why this is required - it seems to be though

Line 62, the problem seems to be multi-part. I haven't gotten it fixed, but I've gotten further. Maybe someone who knows more about the drupal code can help me decipher what's going on?

	$form_submits = array_keys($form['#submit']);

$form is not set - changing line 61 to

     $form = call_user_func($form_id);

helps this, but does not fix it, as it becomes $form['submit'] not $form['#submit']. Even if I change line 62 to reference $form['submit'], I can't get any further, as line 64 does not have a valid array. Can someone build on this 'progress' in debugging?

obsidiandesign’s picture

Category: support » bug

Just changing from a 'support request' to a 'bug', sorry I forgot to add that in my last post.

Swift Arrow’s picture

Category: support » bug

I'm confirming these same errors. Additionally, I have some more issues:

1. On the main site (with rollout client installed and enabled) I am not able to add terms to vocabularies. I went through all the motions, added a vocab, and then clicked add terms. The form came up ok. I submitted three terms, each time getting the rollout errors (above) and "term added successfully" green message. However, when I looked at the vocabulary, it had no terms! I tried it again, this time selecting "apply to all sites" and got the same results. It only worked after I disabled rollout.

2. Everytime I choose "apply to all sites" (for example, when switching to clean urls) it goes back to the main admin page, instead of back to where we just were. It does manage to apply the setting to all the sites, however. This is more minor, though.

3. With Rollout, some admin pages just dont work (I cant remember which ones right now, sorry).

4. Rollout applies an "apply across all sites" checkbox above the navigation menu, as well as at the top of forms... Which one are we supposed to use?

I really like it's functionality - makes for adding a module very easy, but configuring the module and configuring other things across the sites still needs tuning.

I hope someone out there is up to the Job!