Closed (fixed)
Project:
Panels
Version:
5.x-2.0-beta1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Jan 2008 at 09:18 UTC
Updated:
30 Jan 2008 at 23:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
wim leersProper patches, please: http://drupal.org/patch/create.
Comment #2
Soren Jones commentedI was receiving the same foreach() warning on the patched line and on two other lines. An updated patch is attached.
Comment #3
merlinofchaos commentedA simpler patch would be to make sure $pv->contexts is always an array() when the object is created/loaded -- and this is also more in line with how the rest of Panels operates.
Comment #4
Soren Jones commentedOkay. Thank you. Like this?
Comment #5
yched commentedI solved this using a simpler patch - prevents records with contexts = "N;" from entering the {panels_views} table.
Not sure this is the cleanest way to do this, though. At least you can pick :-)
Comment #6
yched commentedstatus
Comment #7
Soren Jones commentedThank you. Unfortunately your patch (in comment #5) doesn't work for me. I receive the same foreach() warning as without the patch, just moved down a line from 699 to 700. Any thoughts why?
Comment #8
yched commentedThat's because the patch in #5 doesn't automatically fix your existing panels_views. You need to resave them (no need to change anything)
Comment #9
Soren Jones commentedPerfect. Thank you! I'm using your #5 patch.
Comment #10
nath commentedWorks for me as well. :)
Comment #11
merlinofchaos commentedPatch in #5 is exactly how I do it elsewhere. Thanks! I'll commit this fairly soon.
Comment #12
merlinofchaos commentedCommitted! THanks for the work on this!
Comment #13
jmai commentedI just tried the latest CVS today, unfortunately, I am getting the error above. But when I apply patch #4, I don't get the warnings.
Comment #14
yched commented@jmai : see #8 above - "That's because the patch in #5 (the one that got committed) doesn't automatically fix your existing panels_views. You need to resave them (no need to change anything)"
Comment #15
jmai commentedSorry I wasn't detailed explaining my problem. I did resave and I don't get the warnings anymore, except only when I configure the Mini panels on the content page. That is strange.
Comment #16
alanbold commentedHow do you apply the patch? thanks
Comment #17
yched commentedalanbold : the patch has already been committed (see comment #11), so you don't need to apply it manually, simply grab latest 5.x-2.x-dev release (http://drupal.org/node/128199)
for general instructions on how to apply patches, see http://drupal.org/patch
Comment #18
timmillwoodThis has fixed my 699 error I now have a line 701 and 739 error.
Any ideas?
Comment #19
merlinofchaos commentedjmai, timmilwood: Those might be different problems. Please open new issues with specifics. Thanks.
Comment #20
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.