Could ajaxsubmit have a callback as part of data array?

I think this idea would also allow for form returns to do things like close the form or other similar JS actions.

Not sure if this is the best way to add this - but as proof of concept i tried this:

added module invoke code near end of ajaxsubmit_dispatch function

  $result = module_invoke_all('ajaxsubmit', $form, $result);      // added this line
  
  print drupal_to_js($result);
  exit(); 

and in ajaxsubmit.js at the very end of Drupal.ajaxsubmit.prototype.onsubmit i added:

  // Run Additional Callback if there was one
  if (data['additional_callback']) eval(data['additional_callback']+"("+data['additional_callback_args']+")"); 

this now lets other modules modify the $result array and pass both a callback function and arguments for it in a hook such as with this hook:

// use new ajaxsubmit_hook to only close STF form if were no errors
function umga_ajaxsubmit ($form, $result) {
  if (!$result['data']['errors']) {
    $result['data']['additional_callback'] = 'hideSendIfNoErrors';
    $result['data']['additional_callback_args'] = array('this');
  }
  
  return $result;
}

and with this callback function:

function hideSendIfNoErrors(mynode) {
  var nid = mynode.form.nid.value;
  $("div#send-"+nid+" form").hide();
}

This particular example lets me close the Send To Friend form on submit only if there were no errors - and it leaves it open if there were errors. I will eventually add another hook (hopefully) to re-add a new CAPTCHA to the form if the form submission fails.

Seems to work pretty well.. :)

Using the new ajaxsubmit_hook i also added a "close message" icon to hide the submit was good message (i.e. "email has been sent to popoi@poi.ca").

in same hook call as above i added:

// add message close button
  $message_close = '<div class="close-button"><a href="javascript:;" title="Click to close" onclick="hideMessage(this);"><img src="/themes/umg/images/x.gif"/></a></div>';  
  $result['data']['message'] = $message_close . $result['data']['message'];

btw - no callback used in this example - simply using hook to modify existing $message value.

started working on a new project for some people and sure enough needed my hooks again - for some reason i though this had been committed to cvs; but sadly no. Too bad; hard to imagine using this module where these hooks wouldn't be used.

hey nedjo,

replied to your email before reading this post.. so Dr6? - as i said, i am a bit behind.. and as i didn't say crazy busy.. just launching $20M huge Drupal site today.. hopefully in next week or so i can set up a Dr6 test site and get HEAD rev of your module - i doubt a patch should be too hard.. in Dr5 version this only adds about 3-4 lines of code.

peter..