Download & Extend
Archive » Issues

Cleanup help and related items for Archive 6.x

Posted by keith.smith on January 4, 2008 at 3:44am
Project:Archive
Version:master
Component:Documentation
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

After the earlier patch, I had a copy of the HEAD version on my site, and got interested in it.

Attached is a patch that modifies the Archive module help text to make it conform a bit better to the style most recently adopted by embedded help in Drupal 6.x -- I added some sections, made some more links in the help body, and broke out the HTML from the t() strings to make it easier to translate.

There was a small notice appearing for $page_sep, so I added an initialization of that variable.

If (as the help implied) this module presents a filter for selecting content types, I didn't see any evidence of it (but didn't look closely). The content types *are* selectable by modifying the url from "all" to something like "page" but I didn't see a UI for this feature. Perhaps there is one and I missed it, or perhaps its not working correctly in HEAD.

Please edit, won't fix, or address as you like -- really, I had some extra time waiting for a server drive to image, and so did this.

AttachmentSize
archive_upd.patch6.3 KB
Login or register to post comments

Comments

#1

Posted by Susurrus on January 4, 2008 at 12:33pm
Title:Cleanup help and related items for Archive 6.x» Cleanup help and related items for Archive 5.x
Version:master» 5.x-1.8
Status:needs review» active

Been committed to HEAD, now changes just need to be backported to 5.x branch. Wish there was a setting for that status...

Since we can't set status, changing issue to affect 5.x branch.

#2

Posted by Susurrus on January 4, 2008 at 5:48pm
Title:Cleanup help and related items for Archive 5.x» Cleanup help and related items for Archive 6.x (needs porting to 5.x)
Version:5.x-1.8» master
Status:active» patch (to be ported)

I think this is how the issue should be setup for needing porting to 5.x...

#3

Posted by Susurrus on May 6, 2008 at 6:48pm
Title:Cleanup help and related items for Archive 6.x (needs porting to 5.x)» Cleanup help and related items for Archive 6.x
Component:Code» Documentation
Status:patch (to be ported)» fixed

Not porting to 5.

#4

Posted by Anonymous (not verified) on May 20, 2008 at 6:51pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.