Refactor loading of checking extensions
Susurrus - January 4, 2008 - 17:26
| Project: | Coder |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (code needs review) |
Description
So far all the checks that can be performed by coder.module involves extra .inc files. The checking data returned by these modules is rather obfuscated compared to how it could be. Extensions such as the 4.7->5.0 upgrade use this code to return the rules return array('upgrade47' => $review);. From an API standpoint, that doesn't make much sense. The function coder_EXTENSIONNAME_reviews() should return just an array and the module should integrate it into whatever data structure it wants.
| Attachment | Size |
|---|---|
| coder.patch | 3.29 KB |
#1
I didn't realize this, but I've also included a change that checks for a #link attribute on the rules returned by an externsion before attempting to create a link out of the extension name. I did this for release checker #206355: Extension to check code before release.
#2
I've tested this and it works. However I've re-rolled the patch against the latest version, removed the #link stuff for #206355 and added in the missing change to includes/coder_sql.inc.
I'm happy with this patch but if anyone else could test it too, that would be great.
Cheers,
Stella