GHOP #126: add workflow-ng integration

http://code.google.com/p/google-highly-open-participation-drupal/issues/...

ok, here is a use case:
Take this tutorial: http://drupal.org/node/156317 - a simple reviewing system. With this actions, it could be easily enhanced. E.g. one could use content access to hide the articles from anonymous users. When an article is published, a content access action is used to enable view access for anonymous users. So it's not possible for anonymous users to view content, which needs work or is under review, but they can read published articles!

I like that you are reusing the existing page form, however please improve the comments a bit: Note, that the action configuration form uses this function without $node.

* Then your forgot to add an optional parameter $node to function content_access_page_form($defaults = array().

* Please add the workflow-ng code as separate include file, which is included when the workflow-ng module is active

* You forgot a var_dump in your code.

* @label t('Active node') - why active? Please don't call nodes "nodes" in the workflow-ng UI. workflow-ng uses 'content'

* This code conflicts with the code style:
+ // Make sure defaults array is full
+ foreach (array('view', 'update', 'delete') as $i) {
+ if (!isset($defaults[$i])) $defaults[$i] = array();
+ }

If you want to do this with a short code, you could use

  $defaults += array('view' => array(), 'update' => array(), 'delete' => array());

* I don't like content_access_parse_settings(). The idea to share the settings code is nice, however in this case I wouldn't go this way. The original page settings saving code was simpler and easier to understand. Furthermore the parameters of content_access_parse_settings() aren't really intuitive - so better eliminate this function and don't share this code for both cases. Of course you can still use this function just for the actions/conditions submit handler, which should simplify it a bit.

* Furthermore content access is now stable for quite a long time. Try to don't change code where it isn't necessary!

* So also, please don't add content_access_get_ops(). Imho it's a bit more intuitive to read the old way. So also just use array('view', 'update', 'delete') instead.

* There is no need to add ACL workflow-ng integration to content access. This should go into the ACL module. So you can remove the comments, that this could be added later

* @ // No error, just fail the condition
If the condition is misconfigured, I think it's better to also go with the error.

* '#description' => t('Evaluates to TRUE, if node allows all selected operations for given roles.'),
Don't use "node" in workflow-ng's UI. Use 'content'.

code style:

* It's FALSE not false, also TRUE instead of true. Please correct this.

* it's
}
else

and not
+ } else {

* an if should always have {}
e.g.
+ foreach (content_access_get_ops() as $op) {
+ if (!isset($defaults[$op])) $defaults[$op] = array();
+ }

--->

  foreach (content_access_get_ops() as $op) {
     if (!isset($defaults[$op])) {
         $defaults[$op] = array();
     }
   }

* Including files is usually done in the beginning of a file. Please move this to the top. Furthermore it's not "drupal" to use "dirname(__FILE__)". do it like this one:

include_once(drupal_get_path('module', 'workflow_ng_ui') .'/workflow_ng_ui_render.inc');

* Try to avoid variable names that aren't readable like "$cur_roles".

apart from that, code looks good!

thanks! from looking at the code the patch looks good now :) However, I had problems applying it. Have you created the patch for the latest content access version? Looks like you have used content access 1.2 or so.

Best create it for the the latest code in the DRUPAL-5 branch or the latest development version.

thanks, now it applies fine. However when testing I ran over a problem: The node grants were not applied.

The problem is that the action just configures content access, but doesn't update the node grants. Best just modify the actions to return the node to be saved - that should do it as node grants are updated when the node is saved. Letting workflow-ng save the node makes sure that it is only done, when it's really necessary. As e.g. on node submit the node is saved nevertheless.

Just fix that, then it's ready :)

thanks, committed to 5.x-1.x-dev. Good work :)
Please upload your latest code to the google issue too.

You can verify the grants e.g. with the devel node access module part of the "devel" project.
I've also deleted the content of the unused HEAD branch.