well it does not work like it should.

First of all there is a bug that causes following pgsql error:
pg_query(): Query failed: ERROR: invalid input syntax for integer: "page" in /home/dodobas/public_html/drupal-pg/includes/database.pgsql.inc on line 45.

this happens when you enable queue module, and try to add any kind of content by clicking on create content.
AFAIK mysql is immune to integer related errors.
Anyway after changing following line in queue.module:
238: $node = node_load(array('nid' => $id));
to
238: $node = node_load(array('type' => $id));
the query is working normally. I don't know is this what is intended for that query to do, but it fixes the problem.

Other problems i just don't know how to "fix". When i finally create content and put it in moderation 'queue' displaying of posts in moderation queue is not ok. After i make a 'vote' content of submission queue does not get rendered properly. Instead of properly SUMing up the votes, and showing only one item, it shows duplicate items. And i think that the number of duplicate items depends on number of users votes, but i could be wrong...

As I recall submission queue in Drupal 4.5.2 worked fine....

CommentFileSizeAuthor
#3 queue_fix_plus.patch1.75 KBjose reyero
#1 queue_fix.patch1.43 KBdodobas

Comments

dodobas’s picture

dodobas commented
StatusFileSize
new queue_fix.patch1.43 KB
dodobas’s picture

dodobas commented

i forgot to explain it:
1. postgres integer problem fixed
2. multiple display of nodes in submission queue was caused by wrong group by statment

also i think that queue module is still underdevloped, and can't think of a way to use it ...

jose reyero’s picture

jose reyero commented
StatusFileSize
new queue_fix_plus.patch1.75 KB

The node count for the moderation page is also wrong,

Just added one more line to the patch.

Changed priority to critical, as these bugs render the submission queue unusable.

jose reyero’s picture

jose reyero commented

Seems I cannot change priority to crital :-)

Anyway, the status should be patch

Steven’s picture

Steven commented

That line 238 fix looks very bogus. You can't just change one column selection to another. It is intended to show a node's moderation results in the sidebar.

dodobas’s picture

dodobas commented

Maybe i can't, but before I "fixed" it, it was comparing node types with node id's, and like i said mysql doesn't report error when comparing integers with some non number value, pgsql does!

At least that query now returns rows, are those the "right" rows, I just don't know...

Maybe the trouble is with var '$id'...

Wes Cowley’s picture

Wes Cowley commented

I played with this one a bit in my sandbox installation. The first set of changes to the SQL selects seem to be correct, they eliminate the duplicate rows in the submission queue list.

The change to line 238 is wrong though. What works for me is changing:

        if (arg(0) == 'queue') {
          $id = arg(1);
        }
        else {
          $id = arg(2);
        }

to simply:

        $id = arg(1);
magico’s picture

magico commented
Component: queue.module » other
Status: Active » Closed (fixed)

queue.module no longer exists.