menu item title callbacks are not properly unserialized. [#206510]

From bug turned up here: http://drupal.org/node/206272

The title arguments are not unserialzed, so this test:

if (empty($item['title_arguments'])) {

in http://api.drupal.org/api/function/_menu_item_localize/6 and a couple other places always returns FALSE! Since it's testing
if (empty('a:0:{}')) {

Attached patch is a start, but now some things try to get unserialized twice.

Comment	File	Size	Author
#2	title_arguments.patch	1.21 KB	chx
#1	unserialize-title-callback-206510-1.patch	1.98 KB	pwolanin

Comments

Comment #1

pwolanin commented 5 January 2008 at 03:24

Status:

Needs work

» Needs review

Status	File	Size
new	unserialize-title-callback-206510-1.patch	1.98 KB

ok - this works, and simplifies the logic of the code a little, since t() doesn't care if we pass an empty array as the second argument.

Comment #2

chx commented 5 January 2008 at 21:58

Status	File	Size
new	title_arguments.patch	1.21 KB

I do not like this solution. You call a lot of serialize totally unnecessary. I would rather make that empty succeed by storing empty string for empty title arguments which is the majority of the cases.