I spent a good hour or so tonight on IRC (with the help of christefano) trying to figure out why editablefields wouldn't work on my site. I installed it, activated it, and created a view of type "Editable table". However, in my Fields, I could not set the Option for a field to "Editable", because that option wouldn't appear.

After looking through the module code, I found an extra comma at the end of line 53, which I believe caused a syntax error in PHP. I erased the comma, and voila, the module started working. There is another issue for this module which I'm guessing would be solved by removing that comma.

Attached is a patch that deletes the comma.

CommentFileSizeAuthor
editablefields_straycomma.patch354 byteschadwick wood

Comments

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Postponed (maintainer needs more info)

I don't think that's the reason. I use commas after the final item in my arrays all the time. The PHP docs say that's "unusual...[but] valid syntax". What version of PHP are you using? Can you confirm in the Apache error logs that there is an error being thrown?

I believe it was an out of date views cache, which would mean you could put the comma back and it would still work.

chadwick wood’s picture

chadwick wood commented

I removed the comma, and it started working. Prior to that, I had cleared all of my caches, just to make sure. I'm pretty sure it was the comma. I didn't check my Apache logs, so I can't answer your question, but I can say for sure that it was not a views cache issue.

Island Usurper’s picture

Island Usurper commented

I'm pretty sure it's not the comma. What happens if you put it back? You can see the Apache logs then. What version of PHP are you using? What is the error reporting set to?

mckeen_greg’s picture

mckeen_greg commented

I can confirm that this doesnt do anything. Using the latest version of Drupal 5, and 5.x-3.3 of Editable Fields with AjaxEditable dev.

My View, I made Editable - Table. However, my Content Type view does not show the field when I select its display to be Editable.

acidpotato’s picture

acidpotato commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Closing legacy issue. Reopen as needed.