After upgrading drupal to 4.6 (and upgrading the phptemplate theme engine as well) I notice that the tabs on node pages (like Edit, Outline, Track) are "squished together" for lack of a better term, with the corresponding text just overflowing their borders. It appears to be an issue in the css file with the placement of the tab-left.png background image and the negative pixel value. Here's the code snippet (from style.css) that I believe to be the problem. 

ul.primary li a .lw1 { 
  margin: 0px; 
  padding: 4px 15px 0px;
  display: block;     
  background: url(tab-left.png) no-repeat 0% -38px;
  border-width: 0px;
  height: 20px;
  text-decoration: none;
  line-height: 20px;
  cursor: pointer;
} 
#main ul.primary li a:hover .lw1 {
  background: url(tab-left.png) no-repeat 0% -76px;
  border-width: 0px;
} 
#main ul.primary li.active a .lw1, #main ul.primary li.active a:hover .lw1 {
  background: url(tab-left.png) no-repeat 0% 0px;
  border-width: 0px;
  color: #000;
}

I attached a screenshot of the problem, but it can also be found here
This may be a simple fix, (for all that I know) but I figured it was a sufficiently big enough problem to warrant mentioning.

CommentFileSizeAuthor
friendselectric-tabs.png11.43 KBdavek@davekaufman.net

Comments

Steven’s picture

Steven commented

Can you confirm this with the latest version of FriendsElectric?

davek@davekaufman.net’s picture

davek@davekaufman.net commented

As far as I know, I have the latest version...it's the same one that is listed on the projects page, anyhow. (4.5)
I also forgot to mention that I reprouced the bug in Firefox q.0+(Windows, Linux, and Mac), IE6 (Win), Camino 0.8.3, and Sarari 1.3, if that helps any.

Hinnerk’s picture

Hinnerk commented

-cvs (from http://drupal.org/files/projects/friendselectric-cvs.tar.gz) works fine on 4.6.0, tested with firefox and Safari, -4.5.0 has the problem (which seems obvious to me?).

Thanks to Steven for this excellent theme!

davek@davekaufman.net’s picture

davek@davekaufman.net commented

Yes, the fix was to install the cvs version, which I was too stupid to find on my own, apparently. It might also be worth noting what the fix actually was, so here's the diff on template.php that dixed the problem (complete credit to Steven on this, I am just posting the code to show what the fix was).

diff /tmp/friendselectric-cvs/template.php /tmp/friendselectic-4.5/template.php 

24,26c24,33
< function phptemplate_menu_item_link($item, $link_item) {
<   /* Wrapper span */
<   return l('<span class="lw1">'. check_plain($item['title']) .'</span>', $link_item['path'], array_key_exists('description', $item) ? array('title' => $items['description']) : array(), NULL, NULL, FALSE, TRUE);
---
> function phptemplate_menu_item($mid) {
>   $menu = menu_get_menu();
> 
>   $link_mid = $mid;
>   while ($menu['items'][$link_mid]['type'] & MENU_LINKS_TO_PARENT) {
>     $link_mid = $menu['items'][$link_mid]['pid'];
>   }
> 
>   /* Wrapper div */
>   return l('<span class="lw1">'. $menu['items'][$mid]['title'] .'</span>', $menu['items'][$link_mid]['path'], array_key_exists('description', $menu['items'][$mid]) ? array("title" => $menu['items'][$mid]['description']) : array());

confirmed fixed on Safari 1.3, Firefox 1.0+ for both Linux and Mac, and Camino 0.8.3

Anonymous’s picture

(not verified) commented
Mike in Maine’s picture

Mike in Maine commented

I believe I have the latest version and I still have this problem in both firefox and IE.