Project:Suggested Terms
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

Hi

Thank you for a great module.

I've made some minor changes to the javascript file, so terms can be both added and removed using the clickable list.
I've also added a 'selected' class to any selected terms, to help theming this module.

I sorry but I don't know how to create a patch, so I attached the modifed javascript file instead. Hope that's ok.

AttachmentSize
suggestedterms.js_.txt1.34 KB

Comments

#1

D'Oh! And right after I release a 1.1 stable, too. :-) Sounds like a nice feature.

Please create a proper patch so that other people can review it properly. See: http://drupal.org/patch/create

Thanks.

#2

Thanks, I'll give it a try.

#3

Status:active» needs review

Ok, here's the patch.

This is my first patch ever, so I hope everything is as it's supposed to be :-)

AttachmentSize
suggestedterms.js_.patch 2.18 KB

#4

Status:needs review» needs work

So I'm finally getting back to this, and the patch doesn't apply. :-( Sorry. Also, please make sure you use Unix line endings, not Windows line endings. Thanks.

#5

Version:5.x-1.x-dev» 6.x-1.x-dev

New features are only being accepted in the 6.x branch now.

#6

Title:Remove exciting terms on click» Remove terms on click
Status:needs work» needs review

Here's another patch for removing terms. It is completely new and does not build upon the work of the previous contributor in this thread.

AttachmentSize
remove_terms.patch 1.91 KB

#7

Here's an "enhanced" patch that adds some logic and css to make terms that are selected to display as red hyperlinks. Terms go back to the default link color when the term is removed.

AttachmentSize
remove_enhanced.patch 5.02 KB
nobody click here